SONARPHP-683 Rule: Cognitive Complexity of functions should not be too high #173
Conversation
| public void visitCatchBlock(CatchBlockTree tree) { | ||
| complexity.addComplexityWithNesting(tree.catchToken()); | ||
|
|
||
| complexity.incNesting(); |
There was a problem hiding this comment.
This seems a perfect case for FP, so I propose to remove all this duplication with a little wrapper in CognitiveComplexity :
public void nestAndDo(Runnable action) { level++; action.run(); level--;}
Which will let you replace all these things with calls like complexity.nestAndDo(() -> super.visitCatchBlock(tree));
| } | ||
|
|
||
| @Override | ||
| public void visitBinaryExpression(BinaryExpressionTree tree) { |
There was a problem hiding this comment.
I suggest to first flatten the BinaryExpressionTree in a list of operators that reproduces the original syntax : [AND,OR,AND] and only after we have that list we calculate the complexity on it by scanning from left to right.
The algorithm to flatten could be something like :
list = new_empty_list
i = 0
flatten(i, list, tree)
function flatten(i, list, tree)
list.add(i,tree)
flatten(i, list, tree.left)
flatten(++i, list, tree.right)
end_function
vilchik-elena
force-pushed
the
SONARPHP-683
branch
from
44e13d8 to
81affa1
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
| statements.forEach(statementTree -> statementTree.accept(this))); | ||
| } | ||
|
|
||
| private void visitWithNesting(Runnable action) { |
There was a problem hiding this comment.
Remove this unused private "visitWithNesting" method. 
vilchik-elena
force-pushed
the
SONARPHP-683
branch
from
b1b9ee8 to
94056f0
Compare
No description provided.