Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crowd 2.1.2 #20

Merged
merged 2 commits into from Jun 11, 2019
Merged

Crowd 2.1.2 #20

merged 2 commits into from Jun 11, 2019

Conversation

deepy
Copy link
Contributor

@deepy deepy commented Jun 4, 2019

Adds 2.1.2 and archives 2.1, 2.1.1 (as no functionality has changed and compatibility is improved)

ganncamp
ganncamp previously requested changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@ganncamp ganncamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question about 2.1 can be ignored if you like, but the compatibility range for 2.1.2 must be fixed before I can merge.

crowd.properties Outdated Show resolved Hide resolved
crowd.properties Show resolved Hide resolved
@deepy
Copy link
Contributor Author

deepy commented Jun 11, 2019

I've updated the PR @ganncamp, thank you for the assistance :-)

@ganncamp ganncamp dismissed their stale review June 11, 2019 15:22

necessary change handled

@ganncamp ganncamp merged commit 1060df9 into SonarSource:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganncamp ganncamp ganncamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@deepy @ganncamp