From 63ef497ede0dad6346d039bf8745d0cf8b0636f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Aubert?= Date: Thu, 9 Nov 2017 15:06:09 +0100 Subject: [PATCH] SONAR-10054 Fix error when changing rule severity for a quality profile --- .../coding-rules/rule/rule-profiles-view.js | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/server/sonar-web/src/main/js/apps/coding-rules/rule/rule-profiles-view.js b/server/sonar-web/src/main/js/apps/coding-rules/rule/rule-profiles-view.js index cc2db14af0d1..9609182b9ca4 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/rule/rule-profiles-view.js +++ b/server/sonar-web/src/main/js/apps/coding-rules/rule/rule-profiles-view.js @@ -54,35 +54,36 @@ export default Marionette.CompositeView.extend({ }, activate() { - const that = this; const activationView = new ProfileActivationView({ rule: this.model, collection: this.collection, app: this.options.app }); activationView.on('profileActivated', (severity, params, profile) => { - if (that.options.app.state.get('query').qprofile === profile) { + if (this.options.app.state.get('query').qprofile === profile) { const activation = { severity, params, inherit: 'NONE', qProfile: profile }; - that.model.set({ activation }); + this.model.set({ activation }); } - that.refreshActives(); + this.refreshActives(); }); activationView.render(); }, refreshActives() { - const that = this; - this.options.app.controller.getRuleDetails(this.model).done(data => { - that.collection.reset( - that.model.getInactiveProfiles(data.actives, that.options.app.qualityProfiles) - ); - this.options.app.controller.updateActivation(this.model, data.actives); - }); + this.options.app.controller.getRuleDetails(this.model).then( + data => { + this.collection.reset( + this.model.getInactiveProfiles(data.actives, this.options.app.qualityProfiles) + ); + this.options.app.controller.updateActivation(this.model, data.actives); + }, + () => {} + ); }, serializeData() {