New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance bikeshedding #14

Closed
notpushkin opened this Issue Feb 11, 2017 · 4 comments

Comments

Projects
None yet
1 participant
@notpushkin
Member

notpushkin commented Feb 11, 2017

Some things to consider:

  • Bublé instead of Babel (for a cleaner and more performant code)
    • Alternatively, don't use transpiling altogether, we might be okay with what recent versions of Electron use
  • Rollup (so that we don't need to deal with bundling node_modules at all)
@notpushkin

This comment has been minimized.

Show comment
Hide comment
@notpushkin

notpushkin Feb 11, 2017

Member

Bublé is a no-go for now as it doesn't understand async/await (which is only logical because it's ES2017). But we can disable ES2015/2016 Babel transforms because they're mostly supported by Electron now (related: http://node.green/)

Lines: 571 vs 757
Bytes: 176K vs 188K

Member

notpushkin commented Feb 11, 2017

Bublé is a no-go for now as it doesn't understand async/await (which is only logical because it's ES2017). But we can disable ES2015/2016 Babel transforms because they're mostly supported by Electron now (related: http://node.green/)

Lines: 571 vs 757
Bytes: 176K vs 188K

@notpushkin

This comment has been minimized.

Show comment
Hide comment
@notpushkin

notpushkin Feb 11, 2017

Member

Okay, and bundling all that stuff is a little over my head, let's leave that for another time.

Member

notpushkin commented Feb 11, 2017

Okay, and bundling all that stuff is a little over my head, let's leave that for another time.

@notpushkin

This comment has been minimized.

Show comment
Hide comment
@notpushkin

notpushkin Feb 11, 2017

Member
yarn.lock    | 337 ++-------------------------------------------------------------------------------------------------------------------------------------------------

Heh, interesting

Member

notpushkin commented Feb 11, 2017

yarn.lock    | 337 ++-------------------------------------------------------------------------------------------------------------------------------------------------

Heh, interesting

notpushkin pushed a commit that referenced this issue Feb 17, 2017

Alexander Pushkov
Switch to babel-plugin-async-to-promises
This removes dependency on babel-runtime, which further cuts down the
bundle size from 37M to 22M :)

related: #14

#nowplaying Dusty Kid - Moto Perpetuo
@notpushkin

This comment has been minimized.

Show comment
Hide comment
@notpushkin

notpushkin Feb 17, 2017

Member

I have to admit that all that Babel-tweaking stuff was more of an attempt to produce sane output than to reduce bundle size. 176K vs 188K is nothing, especially noting that I accidentally included yarn.lock in the bundle (132K! it's not included in these 176K though).

Member

notpushkin commented Feb 17, 2017

I have to admit that all that Babel-tweaking stuff was more of an attempt to produce sane output than to reduce bundle size. 176K vs 188K is nothing, especially noting that I accidentally included yarn.lock in the bundle (132K! it's not included in these 176K though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment