cmd.Start() before stdinPipe.Write() #11

Merged
merged 2 commits into from Mar 30, 2016

Projects

None yet

3 participants

@fujiwara
Contributor

I've experienced horenso could not run reporters and running forever, after the command was completed with huge output (more than about 32KB).

for example

$ horenso -r cat -- perl -E 'say "x" x 32768'
xxxxx
....
xxxxx
(horenso running forever)

cmd.CombinedOutput() calls cmd.Start() and cmd.Wait().
stdinPipe.Write() will be blocked when write byte size is more than pipe buffer, because cmd is not started.

fujiwara added some commits Mar 29, 2016
@fujiwara fujiwara cmd.Start() before stdinPipe.Write()
cmd.CombinedOutput() calls cmd.Start() and cmd.Wait().
stdinPipe.Write() will be blocked when write byte size is more than pipe buffer, because cmd is not started.
d6350b3
@fujiwara fujiwara add script for TestRunHugeOutput
a61d8b4
@coveralls

Coverage Status

Coverage decreased (-7.9%) to 77.473% when pulling a61d8b4 on fujiwara:huge-output into c9dab69 on Songmu:master.

@Songmu Songmu merged commit 723883a into Songmu:master Mar 30, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-7.9%) to 77.473%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment