New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the magic login submodule #95

Merged
merged 12 commits into from Nov 29, 2017

Conversation

Projects
None yet
4 participants
@ebihara99999
Contributor

ebihara99999 commented Nov 29, 2017

See here: #8

I add tests to the magic login submodule, and change some codes accordingly.

I hope it makes easy for magic login to be merged!

@Ch4s3

This comment has been minimized.

Show comment
Hide comment
@Ch4s3

Ch4s3 Nov 29, 2017

Contributor

Much better now that there are tests! I'll go ahead an merge this, but can you add info about this to the wiki?

Contributor

Ch4s3 commented Nov 29, 2017

Much better now that there are tests! I'll go ahead an merge this, but can you add info about this to the wiki?

@Ch4s3 Ch4s3 merged commit 5f05584 into Sorcery:master Nov 29, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ch4s3

This comment has been minimized.

Show comment
Hide comment
@Ch4s3

Ch4s3 Nov 29, 2017

Contributor

Thanks @ebihara99999!

Contributor

Ch4s3 commented Nov 29, 2017

Thanks @ebihara99999!

@Ch4s3 Ch4s3 referenced this pull request Nov 29, 2017

Closed

Add Magic Login submodule #8

@ebihara99999 ebihara99999 deleted the ebihara99999:feature/magic-login branch Nov 30, 2017

@ebihara99999

This comment has been minimized.

Show comment
Hide comment
@ebihara99999

ebihara99999 Nov 30, 2017

Contributor

@Ch4s3
It's OK to add contents to wiki, but I start to work on it in at most 2 weeks because I'm in vacation tomorrow.

Contributor

ebihara99999 commented Nov 30, 2017

@Ch4s3
It's OK to add contents to wiki, but I start to work on it in at most 2 weeks because I'm in vacation tomorrow.

ebihara99999 added a commit to ebihara99999/sorcery that referenced this pull request Mar 10, 2018

Add tests to the magic login submodule (Sorcery#95)
* Add magic login feature

* Use `.nil?` instead of `== nil`

* Prepare for setting up database

- create a migration file for spec
- create a spec to be run and a shared_expmple file

* Add configration tests

change the default of `@magic_login_mailer_disabled` into true because
 the default breaks the tests

* Change the configuration key, magic_login_mailer into magic_login_mailer_class

* Add specs of `.generate_magic_login_token`

* Add specs of `.clear_magic_login_token`

* Add faliure case specs of `.magic_login_email`

* Add success case specs of `.magic_login_email`

* Refactoring: split the success case of the `.generate_magic_login_token` spec into two

* Fix posix compliance offence: No newline at end of file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment