Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for automatic double puppeting #12

Merged
merged 3 commits into from Jan 1, 2020

Conversation

@tulir
Copy link
Contributor

tulir commented Dec 31, 2019

When bridge -> loginSharedSecret is set in the config, the bridge will use matrix-synapse-shared-secret-auth to transparently enable double puppeting after the first successful link command.

Only works for users on the same homeserver as the bridge.

tulir added 2 commits Dec 31, 2019
Completely transparently logs in after the first successful `link`
command using matrix-synapse-shared-secret-auth. Only works for users
on the same homeserver as the bridge.

https://github.com/devture/matrix-synapse-shared-secret-auth
@tulir tulir marked this pull request as ready for review Dec 31, 2019
@Sorunome

This comment has been minimized.

Copy link
Owner

Sorunome commented Jan 1, 2020

If soru understands this correctly the AS doesn't necessarily have to be on the same homeserver as the shared login module thing? So wouldn't a map of homeserver to shared secret make more sense?

@Sorunome

This comment has been minimized.

Copy link
Owner

Sorunome commented Jan 1, 2020

Also, how does this obtain the homeserver URL from the mxid? It could use the existing .well-known resolution

@Sorunome

This comment has been minimized.

Copy link
Owner

Sorunome commented Jan 1, 2020

And maybe for those who don't have .well-known configured an optional homeserver name --> homeserver url mapping.....however that probably is a separate PR. That would also fix matrix-discord/mx-puppet-discord#22 rather elegantly

@Sorunome

This comment has been minimized.

Copy link
Owner

Sorunome commented Jan 1, 2020

Added the homeserver URL mapping in ba666ea

@tulir

This comment has been minimized.

Copy link
Contributor Author

tulir commented Jan 1, 2020

Changed login shared secret config option into a map

@Sorunome

This comment has been minimized.

Copy link
Owner

Sorunome commented Jan 1, 2020

Awesome, thanks a lot!

@Sorunome Sorunome merged commit d4c2a01 into Sorunome:master Jan 1, 2020
@tulir tulir deleted the tulir:automatic-double-puppeting branch Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.