Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Champion select bar stuck in loading #133

Open
OMalenfantThuot opened this issue Feb 13, 2023 · 8 comments
Open

Champion select bar stuck in loading #133

OMalenfantThuot opened this issue Feb 13, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@OMalenfantThuot
Copy link

OMalenfantThuot commented Feb 13, 2023

This is a weird issue.

I installed today's update and the champion search bar stopped working. Now the waiting circle is just spinning non stop.
The "Auto select" button is stuck as well, but the rest of the application is working (of course I'm not getting any rune page as I can't select a champion).

I tried completely uninstalling and resintalling the older version, which was working well before the update and the problem persists, so it's probably not related directly to the last PR.

If anyone has an idea of what could cause this, that'd be great.
Thanks!

@Denidil
Copy link

Denidil commented Feb 13, 2023

I am also experiencing the same problem

@Soundofdarkness
Copy link
Owner

Hm, that is really weird yeah. I'm going to take a look when I have time, but I'm going to assume that maybe something changed on riots end then. Hopefully that's fixable and not something along the lines of them locking down the LCU-Api due to people reading out player names in ranked...

@Soundofdarkness Soundofdarkness added the bug Something isn't working label Feb 13, 2023
@Soundofdarkness Soundofdarkness pinned this issue Feb 13, 2023
@OMalenfantThuot
Copy link
Author

OMalenfantThuot commented Feb 13, 2023

Thanks! Btw, I'm pretty sure it is stuck in the "Do not auto select position" if it makes a difference.

image

@Denidil
Copy link

Denidil commented Feb 13, 2023

The HTTPS certificate for ddragon.leagueoflegends.com seems to have expired. Now you have three options:

* wait until the certificate is renewed

* use HTTP instead of HTTPS for all "ddragon.leagueoflegends.com" (problem solved)

* add something to ignore certificate errors

I noticed that on metasrc itself too.. images weren't loading.

I would suggest a few things to fix Runebook here

A) institute a timeout, instead of jamming the UI, if one of the build providers fails

B) prompt to ask if falling back to HTTP is acceptable when HTTPS fails ("yes", "no" + "don't ask again" checkmark [default on])

@Denidil
Copy link

Denidil commented Feb 13, 2023

Related issue: RiotGames/developer-relations#591

@Denidil
Copy link

Denidil commented Feb 13, 2023

They've renewed the certificate

@OMalenfantThuot
Copy link
Author

Yes it's working now. Thanks!
This might happen again every year, so your suggestions still makes sense.

@Soundofdarkness
Copy link
Owner

Nice to hear its working again!
About the cert part, I will take a look on that when I have time but it might be difficult to fix that without having to hope that stale data is still fine. One way might be to fallback to cdragon too...

@Soundofdarkness Soundofdarkness unpinned this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants