Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect references to commits #833

Merged
merged 1 commit into from Sep 14, 2018
Merged

Detect references to commits #833

merged 1 commit into from Sep 14, 2018

Conversation

@decentralion
Copy link
Member

decentralion commented Sep 14, 2018

Now that #832 gave us logic to parse references to commits, we have the
RelationalView find and add these references. The actual change is
a simple extension of existing reference detection logic.

Test plan: Observe that the snapshots are updated with references to
commits from the example-github repository.

Progress on #815.

@decentralion decentralion requested a review from wchargin Sep 14, 2018
@decentralion decentralion mentioned this pull request Sep 14, 2018
4 of 5 tasks complete
@decentralion decentralion force-pushed the parse-refs-commits branch from 2dd850b to f7a84fd Sep 14, 2018
@decentralion decentralion force-pushed the refs-to-commits branch from a02e439 to 78b4c6b Sep 14, 2018
@decentralion decentralion changed the base branch from parse-refs-commits to master Sep 14, 2018
Now that #832 gave us logic to parse references to commits, we have the
RelationalView find and add these references. The actual change is
a simple extension of existing reference detection logic.

Test plan: Observe that the snapshots are updated with references to
commits from the example-github repository.

Progress on #815.
@decentralion decentralion force-pushed the refs-to-commits branch from 78b4c6b to 55937cd Sep 14, 2018
@decentralion decentralion merged commit aecf64b into master Sep 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@decentralion decentralion deleted the refs-to-commits branch Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.