Skip to content

chore(timeout): parameterize pollTimeout #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2022
Merged

chore(timeout): parameterize pollTimeout #272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6b7ec9
parameterize pollTimeoutMs
Oct 27, 2022
5a35797
Merge pull request #1 from hnara24/pollTimeout
Oct 27, 2022
00a5166
fix(checkstyle): checkstyle violation fix
Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...ew-ui/src/main/java/org/sourcelab/kafka/webview/ui/manager/kafka/config/ClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public class ClientConfig {
/**
* How long to timeout poll requests.
*/
private final long pollTimeoutMs = 2000;
private final long pollTimeoutMs;

/**
* Constructor.
Expand All @@ -89,7 +89,7 @@ private ClientConfig(
final FilterConfig filterConfig,
final String consumerId,
final StartingPosition startingPosition) {
this(topicConfig, filterConfig, consumerId, startingPosition, new ArrayList<>(), 10, true);
this(topicConfig, filterConfig, consumerId, startingPosition, new ArrayList<>(), 10, true, 2000);
}

/**
Expand All @@ -101,6 +101,7 @@ private ClientConfig(
* @param partitionIds List of partitionIds to limit consuming from.
* @param maxResultsPerPartition How many records to poll per partition.
* @param isAutoCommitEnabled If the consumer should auto commit state or not.
* @param pollTimeoutMs poll timeout in milliseconds.
*/
private ClientConfig(
final TopicConfig topicConfig,
Expand All @@ -109,7 +110,8 @@ private ClientConfig(
final StartingPosition startingPosition,
final Collection<Integer> partitionIds,
final int maxResultsPerPartition,
final boolean isAutoCommitEnabled) {
final boolean isAutoCommitEnabled,
final long pollTimeoutMs) {

this.topicConfig = topicConfig;
this.filterConfig = filterConfig;
Expand All @@ -120,6 +122,7 @@ private ClientConfig(
this.partitionIds = Collections.unmodifiableSet(tempSet);
this.maxResultsPerPartition = maxResultsPerPartition;
this.isAutoCommitEnabled = isAutoCommitEnabled;
this.pollTimeoutMs = pollTimeoutMs;
}

public TopicConfig getTopicConfig() {
Expand Down Expand Up @@ -206,6 +209,7 @@ public static class Builder {
private StartingPosition startingPosition = StartingPosition.newResumeFromExistingState();
private int maxResultsPerPartition = 10;
private boolean autoCommit = true;
private long pollTimeoutMs = 2000;

/**
* Private constructor.
Expand Down Expand Up @@ -303,12 +307,22 @@ public Builder withAutoCommitDisabled() {
return this;
}


/**
* Declare pollTimeout in milliseconds.
*/
public Builder withPollTimeoutMs(final long pollTimeoutMs) {
this.pollTimeoutMs = pollTimeoutMs;
return this;
}

/**
* Create new ClientConfig instance.
*/
public ClientConfig build() {
return new ClientConfig(
topicConfig, filterConfig, consumerId, startingPosition, limitPartitions, maxResultsPerPartition, autoCommit);
topicConfig, filterConfig, consumerId, startingPosition, limitPartitions, maxResultsPerPartition,
autoCommit, pollTimeoutMs);
}
}
}