Skip to content

Load WebView separately #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andresilveirah merged 8 commits into from
Mar 29, 2019
Merged

Load WebView separately #23

andresilveirah merged 8 commits into from
Mar 29, 2019

Conversation

@andresilveirah
Copy link
Member

@andresilveirah andresilveirah commented Mar 21, 2019 •
edited
Loading

TL;DR; We now:

  • load the webview in a separate function and call onMessageReady when the message is ready to be shown.
  • no longer add/remove the view from the superview. it's up to the parent to decide if/when the view should be added (we recommend using onMessageReady to add it and onInteractionComplete to remove it)

@andresilveirah andresilveirah force-pushed the load_webview_separately branch from 56a58bb to 1032d1c Compare March 21, 2019 11:54
kavikumra
kavikumra reviewed Mar 25, 2019
View reviewed changes
kavikumra
kavikumra reviewed Mar 25, 2019
View reviewed changes
@andresilveirah
Copy link
Member Author

andresilveirah commented Mar 27, 2019

@kavikumra would you mind having another look?

kavikumra
kavikumra reviewed Mar 28, 2019
View reviewed changes
@andresilveirah andresilveirah merged commit c57503f into master Mar 29, 2019
@andresilveirah andresilveirah deleted the load_webview_separately branch March 29, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kavikumra kavikumra kavikumra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andresilveirah @kavikumra