Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Create new tracking codes module #1
As we discussed on Friday meeting, here is my first version of the module with Criteo implementation. I would like to discuss a few things, just to make sure that we are going in the right direction.
Templates for Criteo are very similar, but different in some parts. For now there are 5 separate templates, for me it would make sense that we place the part that changes depending on a page in a child template and then call it when necessary, although this would make the layout more complicated.
Every template has it's block that inherits from abstract block. Some functionalities that are used across tracking code systems are placed in helpers.
Would you rather place the checks if the feature is enabled in layout or in the block?
Let me know if you think this is the correct approach and then we can continue with the other implementations.