Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer version of websocket #152

Open
iitalics opened this issue Sep 12, 2017 · 4 comments
Open

Use newer version of websocket #152

iitalics opened this issue Sep 12, 2017 · 4 comments
Labels

Comments

@iitalics
Copy link

@iitalics iitalics commented Sep 12, 2017

websocket 0.17 is out of date. More specifically, it pulls in an out of date dependency openssl 0.7.14, which for some awful reason isn't compatible with later openssl implementation (openssel 1.1.0).

@saethlin

This comment has been minimized.

Copy link

@saethlin saethlin commented Jan 24, 2018

The problem is actually much worse than that; just upgrading to weboscket 0.20 will prevent the project from building because we have both an explicit and transitive dependency on an old version of hyper, which depends on openssl 1.0. And since that's a native library, there can only be one version of it in the project.

To fix this, we'd have to move to the latest versions of websocket, hyper, and multipart. The patch that fixes this will be hundreds of lines. I don't know how to break up the patch, because cargo completely refuses to do anything as soon as it detects a dependency on two versions of openssl.

@saethlin

This comment has been minimized.

Copy link

@saethlin saethlin commented Jan 24, 2018

To clarify, I'm going to do the upgrade at least on my own branch of the project. I need these dependencies upgraded so I can link discord-rs in the same binary as slack-rs.

@SpaceManiac SpaceManiac added the tweak label Jan 27, 2018
@fizyk20

This comment has been minimized.

Copy link

@fizyk20 fizyk20 commented Jan 30, 2018

Exactly the same as my use case ;) I looked into updating this quickly myself, but this seems to be such a deep problem that I gave up. If you succeed, do ping me, please!

@saethlin

This comment has been minimized.

Copy link

@saethlin saethlin commented Jan 30, 2018

This branch of a fork is darned close. I submitted a PR to start working, but the maintainer of the fork seems to think they'll have this done in a few days.
https://github.com/tinaun/discord-rs/tree/async_internals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.