New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`:set spell` doesn't work. #209

Closed
Gabirel opened this Issue Feb 4, 2017 · 20 comments

Comments

Projects
None yet
2 participants
@Gabirel
Member

Gabirel commented Feb 4, 2017

Expected behavior

Real time spell check is expected.

SpaceVim doesn't work probably even if <leader>+ts is triggered

Environment Information

  • OS: Arch Linux
  • vim version: vim8.0

@wsdjeg wsdjeg modified the milestone: 0.2.0 Feb 5, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 7, 2017

Member

This Should works well, and this Mapping is just run :set spell, I think you can read :h 'spell'

Member

wsdjeg commented Feb 7, 2017

This Should works well, and this Mapping is just run :set spell, I think you can read :h 'spell'

@wsdjeg wsdjeg closed this Feb 7, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 7, 2017

Member

It works like belows, wrong words well be under line.

2017-02-07-20 55 57

Member

wsdjeg commented Feb 7, 2017

It works like belows, wrong words well be under line.

2017-02-07-20 55 57

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 7, 2017

Member

Have ever created something like spellfile? It fails again to me.

Member

Gabirel commented Feb 7, 2017

Have ever created something like spellfile? It fails again to me.

@wsdjeg wsdjeg reopened this Feb 7, 2017

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 8, 2017

Member

I put something like this:
image

The wired thing happened here:

  1. I just typed z=(z= means show suggestions if it has spell error.)

  2. It shows me like this:
    image

This means spell check do works. But it isn't very willing to mark wrong words to me.
Eg:
image

So, any suggestion?

Member

Gabirel commented Feb 8, 2017

I put something like this:
image

The wired thing happened here:

  1. I just typed z=(z= means show suggestions if it has spell error.)

  2. It shows me like this:
    image

This means spell check do works. But it isn't very willing to mark wrong words to me.
Eg:
image

So, any suggestion?

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 16, 2017

Member

I can not reproduce it in both window xp, win 7, and arch linux.

Member

wsdjeg commented Feb 16, 2017

I can not reproduce it in both window xp, win 7, and arch linux.

@wsdjeg wsdjeg added the No reproduce label Feb 16, 2017

@wsdjeg wsdjeg changed the title from `<leader>`+`ts` Spell Check doesn't work. to `:set spell` doesn't work. Feb 16, 2017

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

I finally know why. But not exactly why.

In my virtualOS, which is Fedora23, I just installed SpaceVim. More importantly, I just pressed \ts. It can find spell errors for me. The picture below can prove:

image

However, I wonder whether my ~/.local.vim is causing this. So I decide to rename my ~/.local.vim into ~/.local.vim.bak. Finally it works for me now.
image

Here's .local.vim:

let g:spacevim_colorscheme  =   'molokai'
let g:spacevim_max_column   =   80
let g:spacevim_error_symbol =   ''
"let g:spacevim_custom_plugins=[
"            \ ['example/vim-example'],
"            \
call SpaceVim#layers#load('lang#lua')
call SpaceVim#layers#load('lang#xml')

Then I discovered that spell check will do the job if I just un-comment let g:spacevim_colorscheme = 'molokai'.

I do really really want to use this molokai theme. Can you fix this since I don't know how to fix this damn tricky thing.

Member

Gabirel commented Feb 16, 2017

I finally know why. But not exactly why.

In my virtualOS, which is Fedora23, I just installed SpaceVim. More importantly, I just pressed \ts. It can find spell errors for me. The picture below can prove:

image

However, I wonder whether my ~/.local.vim is causing this. So I decide to rename my ~/.local.vim into ~/.local.vim.bak. Finally it works for me now.
image

Here's .local.vim:

let g:spacevim_colorscheme  =   'molokai'
let g:spacevim_max_column   =   80
let g:spacevim_error_symbol =   ''
"let g:spacevim_custom_plugins=[
"            \ ['example/vim-example'],
"            \
call SpaceVim#layers#load('lang#lua')
call SpaceVim#layers#load('lang#xml')

Then I discovered that spell check will do the job if I just un-comment let g:spacevim_colorscheme = 'molokai'.

I do really really want to use this molokai theme. Can you fix this since I don't know how to fix this damn tricky thing.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 16, 2017

Member

I just try to add let g:spacevim_colorscheme = 'molokai' to config, it works well.
2017-02-16_1362x726

Member

wsdjeg commented Feb 16, 2017

I just try to add let g:spacevim_colorscheme = 'molokai' to config, it works well.
2017-02-16_1362x726

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

what??!!
WHY? This doesn't work for me if I enable molokai.

Member

Gabirel commented Feb 16, 2017

what??!!
WHY? This doesn't work for me if I enable molokai.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

I'm pretty sure about this. It is molokai that causes this problem. I copied vimfiles into fedora23.

I can reproduce this problem. But you don't. I guess we have different vimfiles.

So, is it necessary for me to delete all of files and reinstall it again?

Member

Gabirel commented Feb 16, 2017

I'm pretty sure about this. It is molokai that causes this problem. I copied vimfiles into fedora23.

I can reproduce this problem. But you don't. I guess we have different vimfiles.

So, is it necessary for me to delete all of files and reinstall it again?

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 16, 2017

Member

Maybe you can have a try, or run git pull in ~/vimfiles.

sorry.

Member

wsdjeg commented Feb 16, 2017

Maybe you can have a try, or run git pull in ~/vimfiles.

sorry.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

I just reinstall everything which SpaceVim needs. Still the same problem.

I can't use spell check when molokai is enabled. What's in your .local.vim? Can you show me please?

Why does it work for you? not for me?

Member

Gabirel commented Feb 16, 2017

I just reinstall everything which SpaceVim needs. Still the same problem.

I can't use spell check when molokai is enabled. What's in your .local.vim? Can you show me please?

Why does it work for you? not for me?

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

I tested on another colorschemes.

colorschemes which seem not to support spellcheck or something are as follows:

  • atom
  • hybrid-material
  • peachpuff
  • pyte
  • ron
  • shine
  • slate
  • torte
  • twilight256
  • wombat256mod
  • zellner
  • Keep testing tomorrow......To Be Continued Tomorrow

Note: some works for me, such as something(default in SpaceVim), solarized and etc.

You could try to reproduce with these colorschemes. If you still cannot reproduce, I think you should really look into this issue.

Member

Gabirel commented Feb 16, 2017

I tested on another colorschemes.

colorschemes which seem not to support spellcheck or something are as follows:

  • atom
  • hybrid-material
  • peachpuff
  • pyte
  • ron
  • shine
  • slate
  • torte
  • twilight256
  • wombat256mod
  • zellner
  • Keep testing tomorrow......To Be Continued Tomorrow

Note: some works for me, such as something(default in SpaceVim), solarized and etc.

You could try to reproduce with these colorschemes. If you still cannot reproduce, I think you should really look into this issue.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 16, 2017

Member

Also

your spellcheck doesn't work very well to be exactly as it shows in the picture above. Because SpaceVim is not a normal correct word. It should get marked by underline just like github does.

image

Member

Gabirel commented Feb 16, 2017

Also

your spellcheck doesn't work very well to be exactly as it shows in the picture above. Because SpaceVim is not a normal correct word. It should get marked by underline just like github does.

image

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 17, 2017

Member

Tested colorschems can be found here: Click Me To Find More ColorSchemes In SpaceVim

colorschemes which seem not to support spellcheck or something are as follows:

  • atom
  • blue
  • darkblue
  • default
  • delek
  • desert
  • elflord
  • evening
  • focuspoint
  • hybrid-material
  • industry
  • koehler
  • molokai(fixed already)
  • molokayo
  • morning
  • murphy
  • pablo
  • peachpuff
  • pyte
  • ron
  • shine
  • slate
  • torte
  • twilight256
  • wombat256mod
  • zellner

@wsdjeg These are colorthemes that seem not to support spell check.

Note: I didn't test all colorthemes in base16-*. Just a few tested. They passed. I guess they belong to the same author who may consider about supporting spell check. So, I ignored testing them all. I wish they all could work.

Member

Gabirel commented Feb 17, 2017

Tested colorschems can be found here: Click Me To Find More ColorSchemes In SpaceVim

colorschemes which seem not to support spellcheck or something are as follows:

  • atom
  • blue
  • darkblue
  • default
  • delek
  • desert
  • elflord
  • evening
  • focuspoint
  • hybrid-material
  • industry
  • koehler
  • molokai(fixed already)
  • molokayo
  • morning
  • murphy
  • pablo
  • peachpuff
  • pyte
  • ron
  • shine
  • slate
  • torte
  • twilight256
  • wombat256mod
  • zellner

@wsdjeg These are colorthemes that seem not to support spell check.

Note: I didn't test all colorthemes in base16-*. Just a few tested. They passed. I guess they belong to the same author who may consider about supporting spell check. So, I ignored testing them all. I wish they all could work.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 17, 2017

Member

I looked into their source code in flatcolor and molokai.

flatcolor ==> flatcolor.vim#L191

molokai ==> molokai.vim#L203

Does it means that molokai doesn't have any underline mark? Just flatcolor has this feature?

flatcolor:
image

molokai:
image

Member

Gabirel commented Feb 17, 2017

I looked into their source code in flatcolor and molokai.

flatcolor ==> flatcolor.vim#L191

molokai ==> molokai.vim#L203

Does it means that molokai doesn't have any underline mark? Just flatcolor has this feature?

flatcolor:
image

molokai:
image

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 17, 2017

Member

Can you test in other terminal? For example termite

Member

wsdjeg commented Feb 17, 2017

Can you test in other terminal? For example termite

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 17, 2017

Member

My terminal is the very normal one, which is xfce4-terminal.

Yes, It has no connection with any terminal. Other terminals have the same problem, including termite.

Have you ever tried other colorschemes? As I said before, your spellcheck doesn't works very well too.

Member

Gabirel commented Feb 17, 2017

My terminal is the very normal one, which is xfce4-terminal.

Yes, It has no connection with any terminal. Other terminals have the same problem, including termite.

Have you ever tried other colorschemes? As I said before, your spellcheck doesn't works very well too.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 17, 2017

Member

You can remote No reproduce label right now. Because I've already know why and how to solve it.

I ported a molokai theme from tomasr/molokai.

Right now, I can use spell check very well.

image

I suggest that you could change ['tomasr/molokai']
into ['Gabirel/molokai']. If you allow me to submit a PR, I can do that. 😃

BTW, it does have few bugs right now. But I can fix those later.

Member

Gabirel commented Feb 17, 2017

You can remote No reproduce label right now. Because I've already know why and how to solve it.

I ported a molokai theme from tomasr/molokai.

Right now, I can use spell check very well.

image

I suggest that you could change ['tomasr/molokai']
into ['Gabirel/molokai']. If you allow me to submit a PR, I can do that. 😃

BTW, it does have few bugs right now. But I can fix those later.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Feb 17, 2017

Member

PR welcome. You can merge @justinmk's molokai fork.

Member

wsdjeg commented Feb 17, 2017

PR welcome. You can merge @justinmk's molokai fork.

@Gabirel

This comment has been minimized.

Show comment
Hide comment
@Gabirel

Gabirel Feb 17, 2017

Member

I've already merged justinmk's molokai.

Also, you should remove No reproduce label right now.

Member

Gabirel commented Feb 17, 2017

I've already merged justinmk's molokai.

Also, you should remove No reproduce label right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment