New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mappings for git blame and git log #1009

Merged
merged 2 commits into from Nov 18, 2017

Conversation

Projects
None yet
3 participants
@crisidev
Contributor

crisidev commented Nov 17, 2017

No description provided.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Nov 17, 2017

Member

for git log,

I think the existing mappings SPC g v and SPC g V is better, it use https://github.com/cohama/agit.vim

Member

wsdjeg commented Nov 17, 2017

for git log,

I think the existing mappings SPC g v and SPC g V is better, it use https://github.com/cohama/agit.vim

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 17, 2017

Codecov Report

Merging #1009 into dev will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##              dev    #1009      +/-   ##
==========================================
+ Coverage   33.74%   33.74%   +<.01%     
==========================================
  Files         219      219              
  Lines        9350     9352       +2     
==========================================
+ Hits         3155     3156       +1     
- Misses       6195     6196       +1

codecov bot commented Nov 17, 2017

Codecov Report

Merging #1009 into dev will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##              dev    #1009      +/-   ##
==========================================
+ Coverage   33.74%   33.74%   +<.01%     
==========================================
  Files         219      219              
  Lines        9350     9352       +2     
==========================================
+ Hits         3155     3156       +1     
- Misses       6195     6196       +1
@crisidev

This comment has been minimized.

Show comment
Hide comment
@crisidev

crisidev Nov 17, 2017

Contributor

@wsdjeg I did not noticed it.. Sorry about that. Would you like to keep the git blame shortcut?

Contributor

crisidev commented Nov 17, 2017

@wsdjeg I did not noticed it.. Sorry about that. Would you like to keep the git blame shortcut?

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Nov 17, 2017

Member

I am ok. but you can not use Gina blame, maybe it should be Gina blame :

Member

wsdjeg commented Nov 17, 2017

I am ok. but you can not use Gina blame, maybe it should be Gina blame :

@lambdalisue

This comment has been minimized.

Show comment
Hide comment
@lambdalisue

lambdalisue Nov 18, 2017

I am ok. but you can not use Gina blame, maybe it should be Gina blame :

Recently it changed. So :Gina blame is OK for now.

lambdalisue/gina.vim@7358cca

lambdalisue commented Nov 18, 2017

I am ok. but you can not use Gina blame, maybe it should be Gina blame :

Recently it changed. So :Gina blame is OK for now.

lambdalisue/gina.vim@7358cca

@wsdjeg wsdjeg merged commit d40fe9e into SpaceVim:dev Nov 18, 2017

5 checks passed

codecov/patch 50% of diff hit (target 33.74%)
Details
codecov/project 33.74% (+<.01%) compared to 325cacb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Nov 18, 2017

Member

Thanks for all of your work.

Member

wsdjeg commented Nov 18, 2017

Thanks for all of your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment