New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable syntax error/warning counts in status line #1040

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@mdavezac
Contributor

mdavezac commented Nov 29, 2017

For some reason, unless I'm mistaken, showing the number of errors in the status line is implemented but not enabled.

More specifically, this PR adds 'syntax checking' to the registered status line sections.
The implementation for syntax checking is the one that existed already.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Nov 29, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Nov 29, 2017

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 29, 2017

Codecov Report

Merging #1040 into dev will not change coverage.
The diff coverage is 10.34%.

@@           Coverage Diff           @@
##              dev    #1040   +/-   ##
=======================================
  Coverage   33.45%   33.45%           
=======================================
  Files         225      225           
  Lines        9506     9506           
=======================================
  Hits         3180     3180           
  Misses       6326     6326

codecov bot commented Nov 29, 2017

Codecov Report

Merging #1040 into dev will not change coverage.
The diff coverage is 10.34%.

@@           Coverage Diff           @@
##              dev    #1040   +/-   ##
=======================================
  Coverage   33.45%   33.45%           
=======================================
  Files         225      225           
  Lines        9506     9506           
=======================================
  Hits         3180     3180           
  Misses       6326     6326
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Nov 30, 2017

Member

Thanks, nice catch!

Member

wsdjeg commented Nov 30, 2017

Thanks, nice catch!

@wsdjeg wsdjeg merged commit eca8961 into SpaceVim:dev Nov 30, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 10.34% of diff hit (target 33.45%)
Details
codecov/project 33.45% remains the same compared to a1a01d0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment