New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_complete: compatiable with macOS. #1054

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
3 participants
@tracyone
Contributor

tracyone commented Dec 1, 2017

Install bash-completion in macOS:

brew "bash-completion"

get_complete: compatiable with macOS.
Install bash-completion in macOS:

brew "bash-completion"
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Dec 1, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Dec 1, 2017

CLA assistant check
All committers have signed the CLA.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 1, 2017

Member

@tracyone can you please sign the cla, thanks.

Member

wsdjeg commented Dec 1, 2017

@tracyone can you please sign the cla, thanks.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 1, 2017

Codecov Report

Merging #1054 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1054   +/-   ##
=======================================
  Coverage   33.22%   33.22%           
=======================================
  Files         225      225           
  Lines        9549     9549           
=======================================
  Hits         3173     3173           
  Misses       6376     6376

codecov bot commented Dec 1, 2017

Codecov Report

Merging #1054 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1054   +/-   ##
=======================================
  Coverage   33.22%   33.22%           
=======================================
  Files         225      225           
  Lines        9549     9549           
=======================================
  Hits         3173     3173           
  Misses       6376     6376
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 1, 2017

Member

@brbsix @tracyone

hi, Thanks for you bash completion script, and I use it for vim's omni func, but as you can see it in this pr, some fixes need to be done, but this file is under lgpl-3.0 License, we can only use it without modified.

Member

wsdjeg commented Dec 1, 2017

@brbsix @tracyone

hi, Thanks for you bash completion script, and I use it for vim's omni func, but as you can see it in this pr, some fixes need to be done, but this file is under lgpl-3.0 License, we can only use it without modified.

@tracyone

This comment has been minimized.

Show comment
Hide comment
@tracyone

tracyone Dec 1, 2017

Contributor

@wsdjeg You are right.

Contributor

tracyone commented Dec 1, 2017

@wsdjeg You are right.

@tracyone tracyone closed this Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment