New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashcomplete: can not trigger omnicomplete in some pos #1061

Merged
merged 4 commits into from Dec 3, 2017

Conversation

Projects
None yet
2 participants
@tracyone
Contributor

tracyone commented Dec 3, 2017

Solution:improve regex.

@wsdjeg this pr solve the issue of bash complete which can be reproduced if you input some space or tab in a empty line.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 3, 2017

Codecov Report

Merging #1061 into dev will increase coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##              dev   #1061      +/-   ##
=========================================
+ Coverage   33.14%   33.2%   +0.06%     
=========================================
  Files         225     225              
  Lines        9592    9607      +15     
=========================================
+ Hits         3179    3190      +11     
- Misses       6413    6417       +4

codecov bot commented Dec 3, 2017

Codecov Report

Merging #1061 into dev will increase coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##              dev   #1061      +/-   ##
=========================================
+ Coverage   33.14%   33.2%   +0.06%     
=========================================
  Files         225     225              
  Lines        9592    9607      +15     
=========================================
+ Hits         3179    3190      +11     
- Misses       6413    6417       +4
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 3, 2017

Member

Got it, thanks, nice PR. will merge it.

Member

wsdjeg commented Dec 3, 2017

Got it, thanks, nice PR. will merge it.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 3, 2017

Member
$ .ci/after_failure.sh
autoload/SpaceVim/api/bash/complete.vim:9:45:Error: EVL103: unused argument `a:CursorPos`
autoload/SpaceVim/api/bash/complete.vim:9:27:Error: EVL103: unused argument `a:ArgLead`
autoload/SpaceVim/api/bash/complete.vim:20:51:Error: EVL103: unused argument `a:CursorPos`
Cloning into 'build/GitHub.vim'...
remote: Counting objects: 721, done.
remote: Compressing objects: 100% (83/83), done.
remote: Total 721 (delta 95), reused 135 (delta 71), pack-reused 556
Receiving objects: 100% (721/721), 127.50 KiB | 2.06 MiB/s, done.
Resolving deltas: 100% (389/389), done.
E282: Cannot read from ".ci/common/github_commenter.vim"
Press ENTER or type command to continue
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@SpaceVimBot

Hi, the bot can not report errors on PRs, Please fix the bot. thanks.

Member

wsdjeg commented Dec 3, 2017

$ .ci/after_failure.sh
autoload/SpaceVim/api/bash/complete.vim:9:45:Error: EVL103: unused argument `a:CursorPos`
autoload/SpaceVim/api/bash/complete.vim:9:27:Error: EVL103: unused argument `a:ArgLead`
autoload/SpaceVim/api/bash/complete.vim:20:51:Error: EVL103: unused argument `a:CursorPos`
Cloning into 'build/GitHub.vim'...
remote: Counting objects: 721, done.
remote: Compressing objects: 100% (83/83), done.
remote: Total 721 (delta 95), reused 135 (delta 71), pack-reused 556
Receiving objects: 100% (721/721), 127.50 KiB | 2.06 MiB/s, done.
Resolving deltas: 100% (389/389), done.
E282: Cannot read from ".ci/common/github_commenter.vim"
Press ENTER or type command to continue
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@SpaceVimBot

Hi, the bot can not report errors on PRs, Please fix the bot. thanks.

@wsdjeg wsdjeg merged commit 91cad9e into SpaceVim:dev Dec 3, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 66.66% of diff hit (target 33.14%)
Details
codecov/project 33.2% (+0.06%) compared to 4faf94a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment