New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARNING!] Implement Sass - second pull request #1083

Merged
merged 5 commits into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@lsrdg
Contributor

lsrdg commented Dec 7, 2017

Sumary:

  • #859 was forgotten and somehow lost. I thought it was merged.
  • that's why I deleted my fork of SP from github.
  • check #859 to know why this PR is being sent again

I found a copy of the old PR on my machine, but couldn't push it back (since I didn't have a fork to push to). I forked SP again, and did the following (omitting the large output below):

$ git pull
$ git add .
$ git commit -m "Pull/push test."
$ git push

According to github, this pull request can be merged, but since I didn't check it manually, caution please.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 7, 2017

Codecov Report

Merging #1083 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1083   +/-   ##
=======================================
  Coverage   33.02%   33.02%           
=======================================
  Files         226      226           
  Lines        9798     9798           
=======================================
  Hits         3236     3236           
  Misses       6562     6562

codecov bot commented Dec 7, 2017

Codecov Report

Merging #1083 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1083   +/-   ##
=======================================
  Coverage   33.02%   33.02%           
=======================================
  Files         226      226           
  Lines        9798     9798           
=======================================
  Hits         3236     3236           
  Misses       6562     6562

@lsrdg lsrdg referenced this pull request Dec 7, 2017

Closed

[WIP] - Implement Sass files #859

@lsrdg

This comment has been minimized.

Show comment
Hide comment
@lsrdg

lsrdg Dec 7, 2017

Contributor

@wsdjeg , have you seen this?

Contributor

lsrdg commented Dec 7, 2017

@wsdjeg , have you seen this?

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 7, 2017

Member

yeah, I will look into it. Thanks.

Member

wsdjeg commented Dec 7, 2017

yeah, I will look into it. Thanks.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 8, 2017

Member

2017-12-08-21-30-44

here is how I test the variables.

Member

wsdjeg commented Dec 8, 2017

2017-12-08-21-30-44

here is how I test the variables.

@wsdjeg wsdjeg merged commit 5c11cc3 into SpaceVim:dev Dec 8, 2017

5 checks passed

codecov/patch Coverage not affected when comparing 8b84e49...5c11cc3
Details
codecov/project 33.02% remains the same compared to 8b84e49
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 8, 2017

Member

merged, thanks!

Member

wsdjeg commented Dec 8, 2017

merged, thanks!

@lsrdg

This comment has been minimized.

Show comment
Hide comment
@lsrdg

lsrdg Dec 8, 2017

Contributor

Nice! Will take a look at the other issues as soon as possible.

Contributor

lsrdg commented Dec 8, 2017

Nice! Will take a look at the other issues as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment