New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue occurd in ALE-enabled environment #1103

Merged
merged 4 commits into from Dec 10, 2017

Conversation

Projects
None yet
2 participants
@sei40kr
Contributor

sei40kr commented Dec 10, 2017

Changes

Fix an issue occurd in ALE-enabled environment

  • Disable caret move hooks unless using Neomake
  • Minor fix for ALE plugin configurations

This PR fixes errors happening when opening buffers without Neomake.
I disabled message update feature when not using Neomake, because it's already implemented ALE plugin itself.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 10, 2017

Member

Thanks, but why so many meregd commits? maybe new PR should check out from dev branch, or rebase dev branch.

Member

wsdjeg commented Dec 10, 2017

Thanks, but why so many meregd commits? maybe new PR should check out from dev branch, or rebase dev branch.

@wsdjeg wsdjeg merged commit 321f801 into SpaceVim:dev Dec 10, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@sei40kr

This comment has been minimized.

Show comment
Hide comment
@sei40kr

sei40kr Dec 10, 2017

Contributor

Sorry, to be honestly, I'm newer to GitHub (and Git system itself).

Contributor

sei40kr commented Dec 10, 2017

Sorry, to be honestly, I'm newer to GitHub (and Git system itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment