New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Lua layer improvements #1134

Merged
merged 7 commits into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@icearith
Contributor

icearith commented Dec 18, 2017

Recently, my development work was done by heavily using Spacevim, the project mainly implemented in Golang, in which, Go layer of Spacevim helped me a lot. Now a new project is gonna scheduled, and the main language is Lua.

Thus, I am gonna port some of the useful mappings form Golang layer to Lua layer. Additionally, some of the language-specific mappings will also be implemented.

This pull request is still in WIP status, so if you have any suggestion or feature requesting. Please feel free to contact me. :)

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 18, 2017

Codecov Report

Merging #1134 into dev will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##              dev    #1134      +/-   ##
==========================================
- Coverage   32.47%   32.46%   -0.02%     
==========================================
  Files         230      230              
  Lines       10190    10194       +4     
==========================================
  Hits         3309     3309              
- Misses       6881     6885       +4

codecov bot commented Dec 18, 2017

Codecov Report

Merging #1134 into dev will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##              dev    #1134      +/-   ##
==========================================
- Coverage   32.47%   32.46%   -0.02%     
==========================================
  Files         230      230              
  Lines       10190    10194       +4     
==========================================
  Hits         3309     3309              
- Misses       6881     6885       +4

@wsdjeg wsdjeg added the WIP label Dec 18, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 18, 2017

Member

Nice work, I think add REPL and runner support will be better. ❤️

Member

wsdjeg commented Dec 18, 2017

Nice work, I think add REPL and runner support will be better. ❤️

wsdjeg and others added some commits Dec 18, 2017

Merge pull request #1136 from SpaceVim/flygrep
Clear cmdline after open file in flygrep
Merge pull request #1139 from techgaun/git-spelling
fix spelling error for stage all files
Merge branch 'fork-lua-layer-improvements' of github.com:icearith/Spa…
…ceVim into fork-lua-layer-improvements

@wsdjeg wsdjeg merged commit 1b87172 into SpaceVim:dev Dec 19, 2017

3 of 5 checks passed

codecov/patch 16.66% of diff hit (target 32.47%)
Details
codecov/project 32.46% (-0.02%) compared to b317dfc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment