New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description to the DOC of golang layer #1140

Merged
merged 9 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@icearith
Contributor

icearith commented Dec 19, 2017

Add the missing documentation of Golang layer. This PR is still in WIP status.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 19, 2017

Codecov Report

Merging #1140 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1140      +/-   ##
==========================================
- Coverage   32.46%   32.46%   -0.01%     
==========================================
  Files         230      230              
  Lines       10191    10194       +3     
==========================================
  Hits         3309     3309              
- Misses       6882     6885       +3

codecov bot commented Dec 19, 2017

Codecov Report

Merging #1140 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1140      +/-   ##
==========================================
- Coverage   32.46%   32.46%   -0.01%     
==========================================
  Files         230      230              
  Lines       10191    10194       +3     
==========================================
  Hits         3309     3309              
- Misses       6882     6885       +3

@icearith icearith changed the title from [WIP] add description to the DOC of golang layer to add description to the DOC of golang layer Dec 19, 2017

@icearith

This comment has been minimized.

Show comment
Hide comment
@icearith

icearith Dec 19, 2017

Contributor

@wsdjeg I just finished this PR, can you review it. :)

Contributor

icearith commented Dec 19, 2017

@wsdjeg I just finished this PR, can you review it. :)

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 19, 2017

Member

LGTM, I will merge it, but I think <plug>(lua) is too short, but maybe this should be fixed in plugin, and I will update the plugin later.

Member

wsdjeg commented Dec 19, 2017

LGTM, I will merge it, but I think <plug>(lua) is too short, but maybe this should be fixed in plugin, and I will update the plugin later.

@wsdjeg wsdjeg merged commit 51c37c5 into SpaceVim:dev Dec 19, 2017

3 of 5 checks passed

codecov/patch 0% of diff hit (target 32.46%)
Details
codecov/project 32.46% (-0.01%) compared to 991fc3b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@icearith icearith deleted the icearith:fork-doc-layer-golang branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment