New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsp support for php #1163

Merged
merged 3 commits into from Dec 23, 2017

Conversation

Projects
None yet
1 participant
@wsdjeg
Member

wsdjeg commented Dec 23, 2017

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]

@wafflebot wafflebot bot added the WIP label Dec 23, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 23, 2017

Codecov Report

Merging #1163 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1163      +/-   ##
==========================================
- Coverage   32.25%   32.22%   -0.03%     
==========================================
  Files         231      231              
  Lines       10258    10267       +9     
==========================================
  Hits         3309     3309              
- Misses       6949     6958       +9

codecov bot commented Dec 23, 2017

Codecov Report

Merging #1163 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1163      +/-   ##
==========================================
- Coverage   32.25%   32.22%   -0.03%     
==========================================
  Files         231      231              
  Lines       10258    10267       +9     
==========================================
  Hits         3309     3309              
- Misses       6949     6958       +9

wsdjeg added some commits Dec 23, 2017

@wsdjeg wsdjeg merged commit 20ed673 into dev Dec 23, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Dec 23, 2017

@wsdjeg wsdjeg deleted the php_lsp branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment