New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c layer doc #1169

Merged
merged 9 commits into from Dec 24, 2017

Conversation

Projects
None yet
2 participants
@wsdjeg
Member

wsdjeg commented Dec 24, 2017

close #1162
ref: neomake/neomake#972
In spacevim, we use .clang to control the argv for c project, these argvs should be applyed to neomake and completion_plugin.

also the spacevim's build-in runner.

cc @blueyed

@wafflebot wafflebot bot added the WIP label Dec 24, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 24, 2017

Codecov Report

Merging #1169 into dev will decrease coverage by 0.11%.
The diff coverage is 12.72%.

@@            Coverage Diff             @@
##              dev    #1169      +/-   ##
==========================================
- Coverage   32.16%   32.05%   -0.12%     
==========================================
  Files         231      232       +1     
  Lines       10287    10339      +52     
==========================================
+ Hits         3309     3314       +5     
- Misses       6978     7025      +47

codecov bot commented Dec 24, 2017

Codecov Report

Merging #1169 into dev will decrease coverage by 0.11%.
The diff coverage is 12.72%.

@@            Coverage Diff             @@
##              dev    #1169      +/-   ##
==========================================
- Coverage   32.16%   32.05%   -0.12%     
==========================================
  Files         231      232       +1     
  Lines       10287    10339      +52     
==========================================
+ Hits         3309     3314       +5     
- Misses       6978     7025      +47

wsdjeg added some commits Dec 24, 2017

wsdjeg added some commits Dec 24, 2017

@wsdjeg wsdjeg merged commit 3014612 into dev Dec 24, 2017

1 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Dec 24, 2017

@@ -159,6 +159,7 @@ function! SpaceVim#autocmds#VimEnter() abort
call SpaceVim#layers#core#tabline#def_colors()
set showtabline=2
endif
call SpaceVim#plugins#projectmanager#RootchandgeCallback()

This comment has been minimized.

@blueyed

blueyed Dec 25, 2017

Contributor

s/chandge/changed/ ?

@blueyed

blueyed Dec 25, 2017

Contributor

s/chandge/changed/ ?

This comment has been minimized.

@wsdjeg

wsdjeg Dec 25, 2017

Member

sorry,it has been merged, But I will fix this type, thank your for reviewing code.

@wsdjeg

wsdjeg Dec 25, 2017

Member

sorry,it has been merged, But I will fix this type, thank your for reviewing code.

@@ -8,7 +8,7 @@ let s:STRING = SpaceVim#api#import('data#string')
function! SpaceVim#layers#checkers#plugins() abort
let plugins = []
if g:spacevim_enable_neomake
if g:spacevim_enable_neomake && g:spacevim_enable_ale == 0
call add(plugins, ['neomake/neomake', {'merged' : 0, 'loadconf' : 1 , 'loadconf_before' : 1}])
elseif g:spacevim_enable_ale

This comment has been minimized.

@blueyed

blueyed Dec 25, 2017

Contributor

I can imagine allowing to enable both Neomake and ALE (even though ALE might complain by default).
I am lazy-loading ALE sometimes after Neomake, just to test / see how it works by now.
I think having one of them doing autolinting, but calling the other manually (e.g. automaking with Neomake, but using ALE's fixer) makes sense.

@blueyed

blueyed Dec 25, 2017

Contributor

I can imagine allowing to enable both Neomake and ALE (even though ALE might complain by default).
I am lazy-loading ALE sometimes after Neomake, just to test / see how it works by now.
I think having one of them doing autolinting, but calling the other manually (e.g. automaking with Neomake, but using ALE's fixer) makes sense.

This comment has been minimized.

@wsdjeg

wsdjeg Dec 25, 2017

Member

I still prefer use one of them by defaule. users can use custom plugins to add ale and ale's config.
but in spacevim, if neomake is enabled, ale will be disabled, and this config will not be applyed to ale. but users still can use spacevim's custom plugin option to add ale.

SpaceVim contains too many plugins now. even though most of them are lazzy loaded. but I user do not want to see plugins with same function are installed at same time.

@wsdjeg

wsdjeg Dec 25, 2017

Member

I still prefer use one of them by defaule. users can use custom plugins to add ale and ale's config.
but in spacevim, if neomake is enabled, ale will be disabled, and this config will not be applyed to ale. but users still can use spacevim's custom plugin option to add ale.

SpaceVim contains too many plugins now. even though most of them are lazzy loaded. but I user do not want to see plugins with same function are installed at same time.

endif
endfunction
if g:spacevim_enable_neomake && g:spacevim_enable_ale == 0

This comment has been minimized.

@blueyed

blueyed Dec 25, 2017

Contributor

Same as above: should not check for g:spacevim_enable_ale here maybe?!

@blueyed

blueyed Dec 25, 2017

Contributor

Same as above: should not check for g:spacevim_enable_ale here maybe?!

" g:ale_c_clang_options
for ft in a:fts
let g:ale_{ft}_clang_options = ' -fsyntax-only -Wall -Wextra -I./ ' . join(a:argv, ' ')
let g:ale_{ft}_clang_executabl = s:clang_executable

This comment has been minimized.

@blueyed

blueyed Dec 25, 2017

Contributor

s/executabl/executable/ ?

@blueyed

blueyed Dec 25, 2017

Contributor

s/executabl/executable/ ?

@wsdjeg wsdjeg deleted the lang_c branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment