New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaScript language server #1170

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Projects
None yet
2 participants
@sei40kr
Contributor

sei40kr commented Dec 25, 2017

  • Deprecate javascript-typescript-stdio
  • Add typescript-language-server

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

  • javascript-typescript-stdio actually uses TypeScript server, and pure TypeScript server has more LSP features.
Update JavaScript language server
* Deprecate `javascript-typescript-stdio`
* Add `typescript-language-server`

@wafflebot wafflebot bot added the WIP label Dec 25, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 25, 2017

Codecov Report

Merging #1170 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1170   +/-   ##
=======================================
  Coverage   32.05%   32.05%           
=======================================
  Files         232      232           
  Lines       10339    10339           
=======================================
  Hits         3314     3314           
  Misses       7025     7025

codecov bot commented Dec 25, 2017

Codecov Report

Merging #1170 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1170   +/-   ##
=======================================
  Coverage   32.05%   32.05%           
=======================================
  Files         232      232           
  Lines       10339    10339           
=======================================
  Hits         3314     3314           
  Misses       7025     7025

@wsdjeg wsdjeg merged commit d6847aa into SpaceVim:dev Dec 25, 2017

5 checks passed

codecov/patch Coverage not affected when comparing 3014612...9993662
Details
codecov/project 32.05% remains the same compared to 3014612
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Dec 25, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 25, 2017

Member

nice!

Member

wsdjeg commented Dec 25, 2017

nice!

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 25, 2017

Member

hmm,sorry!It is wip?

Member

wsdjeg commented Dec 25, 2017

hmm,sorry!It is wip?

@sei40kr

This comment has been minimized.

Show comment
Hide comment
@sei40kr

sei40kr Dec 25, 2017

Contributor

@wsdjeg
I'm going to check which server is better.
Since I'm frontend engineer, I'll try on them and make a conclusion today.
typescript-language-server looks better as far as I read supported LSP features.

Contributor

sei40kr commented Dec 25, 2017

@wsdjeg
I'm going to check which server is better.
Since I'm frontend engineer, I'll try on them and make a conclusion today.
typescript-language-server looks better as far as I read supported LSP features.

@sei40kr sei40kr changed the title from WIP: Update JavaScript language server to Update JavaScript language server Dec 25, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 25, 2017

Member

OK,Thanks

Member

wsdjeg commented Dec 25, 2017

OK,Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment