New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php runner #1174

Merged
merged 4 commits into from Dec 25, 2017

Conversation

Projects
None yet
1 participant
@wsdjeg
Member

wsdjeg commented Dec 25, 2017

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

  1. Add php runner
  2. Fix vim8 support

@wafflebot wafflebot bot added the WIP label Dec 25, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 25, 2017

Codecov Report

Merging #1174 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1174      +/-   ##
==========================================
- Coverage   32.05%   32.01%   -0.04%     
==========================================
  Files         232      232              
  Lines       10339    10351      +12     
==========================================
  Hits         3314     3314              
- Misses       7025     7037      +12

codecov bot commented Dec 25, 2017

Codecov Report

Merging #1174 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1174      +/-   ##
==========================================
- Coverage   32.05%   32.01%   -0.04%     
==========================================
  Files         232      232              
  Lines       10339    10351      +12     
==========================================
  Hits         3314     3314              
- Misses       7025     7037      +12
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 25, 2017

Member

@Shougo

in neovim, we use languageclient-neovim, and the deoplete-source can autocomplete

<?php
ech
?>

echo

but in vim8, we are using vim-lsp, which do not has deoplete source, it is using omni,

so how should I set g:deoplete#omni#input_patterns.php?

I just check https://github.com/autozimu/LanguageClient-neovim/blob/next/rplugin/python3/deoplete/sources/LanguageClientSource.py

It is self.input_pattern = r'(\.|::)\w*'

Member

wsdjeg commented Dec 25, 2017

@Shougo

in neovim, we use languageclient-neovim, and the deoplete-source can autocomplete

<?php
ech
?>

echo

but in vim8, we are using vim-lsp, which do not has deoplete source, it is using omni,

so how should I set g:deoplete#omni#input_patterns.php?

I just check https://github.com/autozimu/LanguageClient-neovim/blob/next/rplugin/python3/deoplete/sources/LanguageClientSource.py

It is self.input_pattern = r'(\.|::)\w*'

wsdjeg added some commits Dec 25, 2017

@wsdjeg wsdjeg merged commit 01058be into dev Dec 25, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Dec 25, 2017

@wsdjeg wsdjeg deleted the php_improve branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment