New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1196 (tab list bug) #1201

Merged
merged 1 commit into from Dec 30, 2017

Conversation

Projects
None yet
3 participants
@everettjf
Contributor

everettjf commented Dec 30, 2017

#1196

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]

@wafflebot wafflebot bot added the WIP label Dec 30, 2017

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Dec 30, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Dec 30, 2017

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 30, 2017

Codecov Report

Merging #1201 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1201      +/-   ##
==========================================
- Coverage   31.79%   31.79%   -0.01%     
==========================================
  Files         234      234              
  Lines       10429    10430       +1     
==========================================
  Hits         3316     3316              
- Misses       7113     7114       +1

codecov bot commented Dec 30, 2017

Codecov Report

Merging #1201 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1201      +/-   ##
==========================================
- Coverage   31.79%   31.79%   -0.01%     
==========================================
  Files         234      234              
  Lines       10429    10430       +1     
==========================================
  Hits         3316     3316              
- Misses       7113     7114       +1

@wsdjeg wsdjeg merged commit ffb3481 into SpaceVim:dev Dec 30, 2017

3 of 5 checks passed

codecov/patch 0% of diff hit (target 31.79%)
Details
codecov/project 31.79% (-0.01%) compared to 8ba5567
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot added Fixed and removed WIP labels Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment