Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new plugin into javascript layer #1270

Merged
merged 3 commits into from Jan 13, 2018

Conversation

@sei40kr
Copy link
Contributor

commented Jan 12, 2018

Changes

Add a new plugin heavenshell/vim-jsdoc, to generate JSDoc annotations
interactively.

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

This plugin provides code generation for JSDoc annotation.
It reads function signature automatically and it can be loaded lazily.

sei40kr added 2 commits Jan 12, 2018
Add a new plugin into javascript layer
Add a new plugin `heavenshell/vim-jsdoc`, to generate JSDoc annotations
interactively
Add key binding to javascript layer
Add key binding to generate JSDoc annotation

@ghost ghost assigned sei40kr Jan 12, 2018

@ghost ghost added the WIP label Jan 12, 2018

@codecov

This comment has been minimized.

Copy link

commented Jan 12, 2018

Codecov Report

Merging #1270 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #1270      +/-   ##
==========================================
- Coverage   31.91%   31.89%   -0.02%     
==========================================
  Files         237      237              
  Lines       10640    10646       +6     
==========================================
  Hits         3396     3396              
- Misses       7244     7250       +6
@wsdjeg

This comment has been minimized.

Copy link
Member

commented Jan 13, 2018

@sei40kr I think the lang#javascript layer document also need to be updated.

Update documentation
Update documentation for javascript layer
@sei40kr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2018

@wsdjeg
Sorry. I've fixed.

@wsdjeg wsdjeg merged commit 981c26c into SpaceVim:dev Jan 13, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 31.91%)
Details
codecov/project 31.89% (-0.02%) compared to bacbf28
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost added Fixed and removed WIP labels Jan 13, 2018

@wsdjeg

This comment has been minimized.

Copy link
Member

commented Jan 13, 2018

@sei40kr Thanks, The key bindings in javascript.vim is wrong, I will fix it, we should not use <leader>j + *, <Leader> means \ in spacevim by default. maybe keep same as java layer will be better.

@wsdjeg wsdjeg added this to the v0.7.0 milestone Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.