Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix in windows 7 #1315

Merged
merged 4 commits into from Jan 22, 2018

Conversation

@Gabirel
Copy link
Member

commented Jan 22, 2018

PR Prelude

  • Use more flexible command to detect
  • Let Pause command work

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]

@Gabirel Gabirel requested a review from wsdjeg as a code owner Jan 22, 2018

@ghost ghost assigned Gabirel Jan 22, 2018

@ghost ghost added the WIP label Jan 22, 2018

@Gabirel

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2018

@wsdjeg I've already tested it. It works for me. Please do one more test in your win7

@codecov

This comment has been minimized.

Copy link

commented Jan 22, 2018

Codecov Report

Merging #1315 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   31.42%   31.42%           
=======================================
  Files         239      239           
  Lines       11015    11015           
=======================================
  Hits         3461     3461           
  Misses       7554     7554
@wsdjeg

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

the default branch is master, and git pull origin dev will cause error.

@wsdjeg

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

is there a function for checking if the path is a link to SpaceVim or directory?

@Gabirel

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2018

  1. What do you mean by this?

the default branch is master, and git pull origin dev will cause error.

I didn't git pull origin dev. And There's no branch called dev.

  1. Which path is linked to SpaceVim? I don't understand it. Maybe no.
@wsdjeg

This comment has been minimized.

@wsdjeg
wsdjeg approved these changes Jan 22, 2018

@Gabirel Gabirel merged commit 64b2342 into SpaceVim:master Jan 22, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 81d2fa9...a664d49
Details
codecov/project 31.42% remains the same compared to 81d2fa9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost added Fixed and removed WIP labels Jan 22, 2018

@Gabirel Gabirel deleted the Gabirel:hotfix-windows branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.