Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github layer #1377

Merged
merged 2 commits into from Feb 6, 2018

Conversation

@sei40kr
Copy link
Contributor

commented Feb 4, 2018

PR Prelude

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

@sei40kr sei40kr requested a review from wsdjeg as a code owner Feb 4, 2018

@ghost ghost assigned sei40kr Feb 4, 2018

@ghost ghost added the WIP label Feb 4, 2018

@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@2e8843e). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1377   +/-   ##
=========================================
  Coverage          ?   31.28%           
=========================================
  Files             ?      240           
  Lines             ?    11141           
  Branches          ?        0           
=========================================
  Hits              ?     3486           
  Misses            ?     7655           
  Partials          ?        0
\ 'on_cmd': ['GHActivity', 'GHDashboard'],
\ }],
\ ['rhysd/github-complete.vim', {
\ 'on_ft': ['gitcommit', 'markdown'],

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 4, 2018

Member

for gitcommit, we have build-in complete function, I do not want to use other plugin for it, but I think it can be enabled in markdown.

This comment has been minimized.

Copy link
@sei40kr

sei40kr Feb 4, 2018

Author Contributor

You mean github-issues.vim? github-complete.vim provides more completion like emoji, username, and issue no, so it looks better to me.
Is there any other reason we should choose github-issues.vim?

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 4, 2018

Member

@sei40kr no, I mean complete issue and pr after #, this is not github-issue.vim, it is build-in plugin,

https://github.com/wsdjeg/SpaceVim/blob/replace/autoload/SpaceVim/plugins/gitcommit.vim

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 4, 2018

Member

for emoji, I think deoplete support multiple source, we can find out an emoji source.

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 4, 2018

Member

using rplugin source will run completion async, if we use omni func, it is not async, it will block your vim before the popmenu is opened.

in deoplete, all source are running async, but only the omni source is not. if you need emoji completion, maybi you can have a try with https://github.com/fszymanski/deoplete-emoji

This comment has been minimized.

Copy link
@sei40kr

sei40kr Feb 4, 2018

Author Contributor

@wsdjeg
I see. I'm going to fix this PR.

This comment has been minimized.

Copy link
@sei40kr

sei40kr Feb 4, 2018

Author Contributor

I considered using github-complete.vim in markdown files, but I decided to add them (emoji/username completions) another time. I'll search ways to include them as asynchronous completions.

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 4, 2018

Member

ok, :) but for commit message, I want to use the build-in plugin. and I will add async and cache support.

Improve github layer
Add header into layer file. Add new plugins.
* tyru/open-browser-github.vim - open GitHub file/issues/PRs in browser
Add key bindings for plugins in github layer. Add README for github
layer.

@sei40kr sei40kr force-pushed the sei40kr:improve-github branch from 9d1e39a to 50a8c25 Feb 4, 2018

@wsdjeg
wsdjeg approved these changes Feb 4, 2018
return [
\ ['jaxbot/github-issues.vim', { 'on_cmd' : 'Gissues' }],
\ ['junegunn/vim-github-dashboard', {
\ 'on_cmd': ['GHActivity', 'GHDashboard'],

This comment has been minimized.

Copy link
@wsdjeg

wsdjeg Feb 5, 2018

Member

Here, we need to add 'GHD','GHA'.

@sei40kr sei40kr force-pushed the sei40kr:improve-github branch from 44bdc65 to a0a696a Feb 6, 2018

@wsdjeg
wsdjeg approved these changes Feb 6, 2018
Copy link
Member

left a comment

LGTM

@wsdjeg wsdjeg merged commit 0d997d2 into SpaceVim:master Feb 6, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost added Fixed and removed WIP labels Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.