New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: json-vim: update to newer, forked version #776

Merged
merged 2 commits into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@tennysontbardwell
Contributor

tennysontbardwell commented Aug 12, 2017

Updated the lang layer to use elzr/vim-json's fork or the old plugin
(leshill/vim-json). Now the actual used plugin is consistent with the
documentation, which pointed to elzr/vim-json before

plugin: json-vim: update to newer, forked version
Updated the lang layer to use elzr/vim-json's fork or the old plugin
(leshill/vim-json). Now the actual used plugin is consistent with the
documentation, which pointed to elzr/vim-json before
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 12, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 12, 2017

CLA assistant check
All committers have signed the CLA.

@tennysontbardwell

This comment has been minimized.

Show comment
Hide comment
@tennysontbardwell

tennysontbardwell Aug 12, 2017

Contributor

I couldn't figure out why the elzr/vim-json plugin didn't seem to be loaded in SpaceVim. I discovered SpaceVim today (I've used Spacemacs!) and a complete lack of syntax highlighting in my package.json files bugged me all day (the old plugin didn't differentiate between keys and values in json). I hope it's ok to update to this package, but I though it'd be better to put this PR out there at least!

Contributor

tennysontbardwell commented Aug 12, 2017

I couldn't figure out why the elzr/vim-json plugin didn't seem to be loaded in SpaceVim. I discovered SpaceVim today (I've used Spacemacs!) and a complete lack of syntax highlighting in my package.json files bugged me all day (the old plugin didn't differentiate between keys and values in json). I hope it's ok to update to this package, but I though it'd be better to put this PR out there at least!

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Aug 13, 2017

Member

this is a lazy loaded plugin, the event is FileType Json you can remove it.

Member

wsdjeg commented Aug 13, 2017

this is a lazy loaded plugin, the event is FileType Json you can remove it.

@wsdjeg wsdjeg merged commit f5e966f into SpaceVim:dev Aug 14, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Aug 14, 2017

Member

I just test this PR, it works well for me.

Member

wsdjeg commented Aug 14, 2017

I just test this PR, it works well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment