New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve tests #872

Merged
merged 7 commits into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@blueyed
Contributor

blueyed commented Oct 4, 2017

Includes #881.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 4, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 4, 2017

CLA assistant check
All committers have signed the CLA.

@blueyed blueyed changed the title from Improve tests to [WIP] Improve tests Oct 4, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 4, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (dev@de43970). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #872   +/-   ##
=====================================
  Coverage       ?   4.41%           
=====================================
  Files          ?     204           
  Lines          ?    8717           
  Branches       ?       0           
=====================================
  Hits           ?     385           
  Misses         ?    8332           
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de43970...e1c4cac. Read the comment docs.

codecov bot commented Oct 4, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (dev@de43970). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #872   +/-   ##
=====================================
  Coverage       ?   4.41%           
=====================================
  Files          ?     204           
  Lines          ?    8717           
  Branches       ?       0           
=====================================
  Hits           ?     385           
  Misses         ?    8332           
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de43970...e1c4cac. Read the comment docs.

@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 4, 2017

Contributor

You have some coverage now at https://codecov.io/gh/SpaceVim/SpaceVim/pull/872/tree.. 🎆

Contributor

blueyed commented Oct 4, 2017

You have some coverage now at https://codecov.io/gh/SpaceVim/SpaceVim/pull/872/tree.. 🎆

@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 5, 2017

Contributor

It currently only report files actually being executed, so your whole coverage is even worse than the 37% - but that is fair considering that you only have less than a handful of tests.

As for covimerage, it should maybe include all the .vim files based on its own glob, so that it also includes not executed files.

Contributor

blueyed commented Oct 5, 2017

It currently only report files actually being executed, so your whole coverage is even worse than the 37% - but that is fair considering that you only have less than a handful of tests.

As for covimerage, it should maybe include all the .vim files based on its own glob, so that it also includes not executed files.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 5, 2017

Member

great work! thanks.

Member

wsdjeg commented Oct 5, 2017

great work! thanks.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 5, 2017

Member

@blueyed Thanks for your works, I just see there are two checks failed, is it due to SpaceVim's tests are too little?

Member

wsdjeg commented Oct 5, 2017

@blueyed Thanks for your works, I just see there are two checks failed, is it due to SpaceVim's tests are too little?

@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 5, 2017

Contributor

@wsdjeg
The checks are expected, since there is nothing to report against.
Later you will see there if coverage increased and if the diff coverage is good etc.
I have something in mind to improve the coverage reporting, by including all source files etc.. I will update this PR later.

For the tests itself, you might want to consider using Vim in Docker (via https://github.com/tweekmonster/vim-testbed, also used for Neomake).
And then it would make sense to use CircleCI instead of Travis, since they have good Docker support (where you can sepcify the image for each job), and it is really fast and more pleasant to use.

Contributor

blueyed commented Oct 5, 2017

@wsdjeg
The checks are expected, since there is nothing to report against.
Later you will see there if coverage increased and if the diff coverage is good etc.
I have something in mind to improve the coverage reporting, by including all source files etc.. I will update this PR later.

For the tests itself, you might want to consider using Vim in Docker (via https://github.com/tweekmonster/vim-testbed, also used for Neomake).
And then it would make sense to use CircleCI instead of Travis, since they have good Docker support (where you can sepcify the image for each job), and it is really fast and more pleasant to use.

@blueyed blueyed referenced this pull request Oct 7, 2017

Merged

Build improvements #881

@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 8, 2017

Contributor

This looks good from my side.
See https://codecov.io/gh/SpaceVim/SpaceVim/tree/e1c4cac000a462828b8345f316803feb5ac842a8 to browse the files.
Maybe you want to omit more, e.g. SpaceVim.d, not sure.

Not sure what your plan is, but in general codecov/this can help to bring the coverage up, e.g. if you at least cover the new code etc.

Contributor

blueyed commented Oct 8, 2017

This looks good from my side.
See https://codecov.io/gh/SpaceVim/SpaceVim/tree/e1c4cac000a462828b8345f316803feb5ac842a8 to browse the files.
Maybe you want to omit more, e.g. SpaceVim.d, not sure.

Not sure what your plan is, but in general codecov/this can help to bring the coverage up, e.g. if you at least cover the new code etc.

@wsdjeg wsdjeg merged commit d471834 into SpaceVim:dev Oct 10, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 10, 2017

Member

@blueyed Thanks, I think it is ok now, the next step I need to do should be add some test for spacevim.

Member

wsdjeg commented Oct 10, 2017

@blueyed Thanks, I think it is ok now, the next step I need to do should be add some test for spacevim.

@blueyed blueyed deleted the blueyed:improve-tests branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment