New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: set -e with script blocks #879

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
2 participants
@blueyed
Contributor

blueyed commented Oct 5, 2017

This makes it fail actually if there are any errors.

Travis: set -e with script blocks
This makes it fail actually if there are any errors.
@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 5, 2017

Contributor

You can see here that vimlint is actually failing, but it was not caught.

Side note: for Travis it should exit with 1 to cause a ailure, anything else (like this) is an error.
Errors are meant for when something in the setupp failed, but this should be a failure.

Contributor

blueyed commented Oct 5, 2017

You can see here that vimlint is actually failing, but it was not caught.

Side note: for Travis it should exit with 1 to cause a ailure, anything else (like this) is an error.
Errors are meant for when something in the setupp failed, but this should be a failure.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 6, 2017

Member

vimlint-errors is failed. the log is:

1Vim(let):E132: Function call depth is higher than 'maxfuncdepth'

I will have a look tonight.

Member

wsdjeg commented Oct 6, 2017

vimlint-errors is failed. the log is:

1Vim(let):E132: Function call depth is higher than 'maxfuncdepth'

I will have a look tonight.

@wsdjeg wsdjeg referenced this pull request Oct 6, 2017

Merged

Travis fix #880

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 6, 2017

Member

@blueyed this is due to there are too many vim files, we need to split the command.
issue is opened here : syngan/vim-vimlint#107

Member

wsdjeg commented Oct 6, 2017

@blueyed this is due to there are too many vim files, we need to split the command.
issue is opened here : syngan/vim-vimlint#107

@wsdjeg wsdjeg merged commit 4053622 into SpaceVim:dev Oct 6, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
license/cla Contributor License Agreement is signed.
Details
@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 8, 2017

Contributor

You could only run it for changed files - reminded me of neomake/neomake#1651 (see the old travis_lint in there).

Contributor

blueyed commented Oct 8, 2017

You could only run it for changed files - reminded me of neomake/neomake#1651 (see the old travis_lint in there).

@blueyed blueyed deleted the blueyed:travis-report-errors branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment