New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer the possibility to add custom palette #922

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@HiBigBob
Contributor

HiBigBob commented Oct 22, 2017

No description provided.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 22, 2017

Codecov Report

Merging #922 into dev will increase coverage by <.01%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##              dev     #922      +/-   ##
==========================================
+ Coverage   32.97%   32.97%   +<.01%     
==========================================
  Files         209      209              
  Lines        8841     8848       +7     
==========================================
+ Hits         2915     2918       +3     
- Misses       5926     5930       +4

codecov bot commented Oct 22, 2017

Codecov Report

Merging #922 into dev will increase coverage by <.01%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##              dev     #922      +/-   ##
==========================================
+ Coverage   32.97%   32.97%   +<.01%     
==========================================
  Files         209      209              
  Lines        8841     8848       +7     
==========================================
+ Hits         2915     2918       +3     
- Misses       5926     5930       +4
@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Oct 22, 2017

Member

Thanks for your PR. how about using g:spacevim_custom_color_plalette instead? BTW, maybe the travis-ci lint needs some fix.

Member

wsdjeg commented Oct 22, 2017

Thanks for your PR. how about using g:spacevim_custom_color_plalette instead? BTW, maybe the travis-ci lint needs some fix.

@HiBigBob

This comment has been minimized.

Show comment
Hide comment
@HiBigBob

HiBigBob Oct 23, 2017

Contributor

I had changed the variable name and fixed travis ;)

Contributor

HiBigBob commented Oct 23, 2017

I had changed the variable name and fixed travis ;)

@wafflebot wafflebot bot added the WIP label Oct 23, 2017

@wsdjeg wsdjeg merged commit 2d7572a into SpaceVim:dev Oct 23, 2017

5 checks passed

codecov/patch 73.33% of diff hit (target 32.97%)
Details
codecov/project 32.97% (+<.01%) compared to dd4d6d2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the WIP label Oct 23, 2017

@HiBigBob HiBigBob deleted the HiBigBob:optional_custom_palette branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment