New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: improve Neomake integration #931

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@blueyed
Contributor

blueyed commented Oct 24, 2017

Ref: #200

Untested.
@wsdjeg
Please pick this up.

@blueyed blueyed referenced this pull request Oct 24, 2017

Closed

recommend plugin:ale #200

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 24, 2017

Codecov Report

Merging #931 into dev will increase coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev     #931      +/-   ##
==========================================
+ Coverage   34.49%   34.54%   +0.05%     
==========================================
  Files         209      209              
  Lines        8860     8847      -13     
==========================================
  Hits         3056     3056              
+ Misses       5804     5791      -13

codecov bot commented Oct 24, 2017

Codecov Report

Merging #931 into dev will increase coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev     #931      +/-   ##
==========================================
+ Coverage   34.49%   34.54%   +0.05%     
==========================================
  Files         209      209              
  Lines        8860     8847      -13     
==========================================
  Hits         3056     3056              
+ Misses       5804     5791      -13
@blueyed

This comment has been minimized.

Show comment
Hide comment
@blueyed

blueyed Oct 24, 2017

Contributor

As recommened in #200 (comment) I would rather not try to wrap Neomake/ALE/Syntastic with extra settings, but rather detect if they are present, e.g. when you want to toggle them or integrate them in the statusline.

Contributor

blueyed commented Oct 24, 2017

As recommened in #200 (comment) I would rather not try to wrap Neomake/ALE/Syntastic with extra settings, but rather detect if they are present, e.g. when you want to toggle them or integrate them in the statusline.

@wsdjeg wsdjeg merged commit 799317c into SpaceVim:dev Oct 25, 2017

6 of 7 checks passed

codecov/patch 0% of diff hit (target 34.49%)
Details
codecov/project 34.54% (+0.05%) compared to 919b93f
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@blueyed blueyed deleted the blueyed:improve-neomake-integration branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment