Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a base abstract class for server engines #30

Closed
alexkiro opened this issue Oct 28, 2014 · 0 comments
Closed

Create a base abstract class for server engines #30

alexkiro opened this issue Oct 28, 2014 · 0 comments
Assignees
@alexkiro
Labels
enhancement Pyzor Server
Milestone
1.0

Comments

@alexkiro
Copy link
Contributor

The servers engines in the pyzor.engines package all respect a certain pattern, and must implement certain methods.

In order to make the package more consistent, and to make adding more engines easier, we should create a base abstract class from which all engines should inherit.
@alexkiro alexkiro self-assigned this Oct 28, 2014
@alexkiro alexkiro added this to the 1.0 milestone Oct 28, 2014
@alexkiro alexkiro changed the title Create a base abstract class for server engeins Create a base abstract class for server engines Oct 28, 2014
alexkiro added a commit that referenced this issue Oct 28, 2014
@alexkiro
Refs. #30. Create a base engine class ``pyzor.engines.common.BaseEngi…
55044ea 
…ne``.

Add a base class for engines with stubs for all methods that require
implementation for a pyzord server engine.

The ``whitelist`` and ``report`` methods are exceptions to this, as
noted in the documentation.
@alexkiro alexkiro closed this as completed Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexkiro alexkiro

Labels
enhancement Pyzor Server
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@alexkiro