Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections always show "last activity note" column #2430

Closed
1 task done
garrettjohnson opened this issue Sep 5, 2017 · 0 comments
Closed
1 task done

Connections always show "last activity note" column #2430

garrettjohnson opened this issue Sep 5, 2017 · 0 comments
Assignees
@shivambareria
Labels
Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v6.10
Milestone
v6

Comments

@garrettjohnson
Copy link
Contributor

garrettjohnson commented Sep 5, 2017 •
edited

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

If the MyConnectionOpportunities block is set to not show the last activity note, a column named "Last Activity Note" is rendered with no contents. When disabled, Rock should hide this column instead of showing a blank column which implies that no notes have been added.
screenshot 2017-09-05 13 35 06

Example Last Activity Note rendered when deselected
screenshot 2017-09-05 13 39 51

Steps to Reproduce

  1. Set my connection opportunities block Show Last Activity Note block setting to No

Expected behavior:

No Last Activity Note column is shown.

Actual behavior:

Last Activity Note column is shown with no contents.

Versions

  • Rock Version: 6.9 - PreAlpha (9/5/2017)
  • Client Culture Setting: en-US
@garrettjohnson garrettjohnson added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Sep 5, 2017
@garrettjohnson garrettjohnson changed the title Connections always show "last activity note" Connections always show "last activity note" column Sep 5, 2017
shivambareria added a commit that referenced this issue Sep 6, 2017
@shivambareria
Fixed #2430 Mapped show last activity note block setting with column
1a83f26
@garrettjohnson garrettjohnson added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Sep 8, 2017
@arranf arranf added the Priority: Low Affects a small number of Rock installations and will not be noticed by most users. label Sep 9, 2017
azturner pushed a commit that referenced this issue Sep 23, 2017
@shivambareria @azturner
+ Fixed the My Connection Opportunities to correctly hide the "Last A…
56fe967 
…ctivity Note" column when configured to not show the note (Fixes #2430).
@crayzd92 crayzd92 added this to the v6 milestone Mar 3, 2022
@chead4 chead4 removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivambareria shivambareria

Labels
Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v6.10
Projects
None yet
Milestone
v6
Development

No branches or pull requests
6 participants
@garrettjohnson @azturner @arranf @shivambareria @crayzd92 @chead4