Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Instructions does not show when "Allow Multiple Registrants = false" #3805

Closed
cabal95 opened this issue Jul 17, 2019 · 4 comments
Assignees
Labels
Status: Attention Core Team The status given to issues that must be handled by the core team. The core analyst determines this. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Event Registration Related to Rock Event Registration. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v9.1
Milestone

Comments

@cabal95
Copy link
Member

cabal95 commented Jul 17, 2019

Description

If the registration is set to not allow multiple registrants, then the screen that shows the registration instructions is skipped.

Originally culled from https://community.rockrms.com/ideas/1278

Jeff says:

I'm not sure it's necessarily a "bug" since the help text on the Registration Instructions says that it displays on the page where they choose how many they're registering.

Steps to Reproduce

n/a

Expected behavior:

Registration instructions should be shown on all registration entry forms.

Actual behavior:

They only show if allow multiple is true.

Versions

  • Rock Version: Rock McKinley 8.8 (1.8.8.3)
  • Client Culture Setting: ??
@cabal95 cabal95 added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Not Yet Reproduced Topic: Event Registration Related to Rock Event Registration. labels Jul 17, 2019
@JRichmond27
Copy link

Steps to Reproduce

  1. Create an Event Registration Template with the Allow Multiple Registrants left unchecked
  2. Add content to the Registration Instructions field on the template
  3. Create an instance of the new template
  4. Go to the registration instance on the public website and notice that the instructions are not shown

Versions

  • Client Culture Setting: en-US

The current help tooltip on the Registration Instructions field currently says:

These instructions will appear at the beginning of the registration process when selecting how many registrants for the registration.

...so this may be working as intended.

@cabal95 cabal95 added Status: Attention Core Team The status given to issues that must be handled by the core team. The core analyst determines this. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. and removed Not Yet Reproduced labels Jul 19, 2019
@cabal95
Copy link
Member Author

cabal95 commented Jul 19, 2019

Was able to reproduce this on the demo site, so marking it as confirmed. But also marking it for the core team to review. As @JRichmond27 says, it may be working as intended, although that may have just been the wording chosen as that happened to be where the text showed up during development/testing not realizing it wouldn't show up if the registration only allows single registrants. Core team can make the call on that.

Thanks Jeff for getting the reproduction steps in!

@ethan-sparkdevnetwork
Copy link
Contributor

ethan-sparkdevnetwork commented Jul 19, 2019

The instructions will now display on the initial screen regardless of the "Allow Multiple Registrants" setting. If allow multiple is selected then the instructions appear next to the number selector control as usual, if not then the instructions display by themselves. If there are no instructions and allow multiple is not enabled the registration skips to the Registrant screen as normal. Also removed the allow multiple caveat from the Instructions help text.

All other functionality has not changed.

@cabal95
Copy link
Member Author

cabal95 commented Jul 19, 2019

Thanks @ethan-sparkdevnetwork, I'm assuming by "display by themselves" means there is a "Continue" or "Start" or whatever button as well so the user can move to the next (initial) screen?

cbump pushed a commit to secc/Rock that referenced this issue Jan 3, 2020
@crayzd92 crayzd92 added this to the v9.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Attention Core Team The status given to issues that must be handled by the core team. The core analyst determines this. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Event Registration Related to Rock Event Registration. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v9.1
Projects
None yet
Development

No branches or pull requests

4 participants