Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication List Segments Disappear During Communication Approvals #4144

Closed
shelbysubia opened this issue Mar 4, 2020 · 0 comments
Closed
Assignees
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v10.3
Milestone

Comments

@shelbysubia
Copy link

shelbysubia commented Mar 4, 2020

Description

The communication list-specific segments (configured on the Communication List group settings) disappear when the communication is submitted for approval, and the approver clicks "Edit". The number of recipients also changes, and the entire communication list is pulled in (instead of the segmented portion of the list). In order to re-segment the list, the communication approver must change the recipient list, change it back to the correct list, wait for the list-specific segments to re-appear, and then re-segment (assuming they can figure out which segments they had).

Communication List Group Settings
image

Staff Member Sets up New Communication List & List-Specific Segment
image

Approver Clicks Edit on Communication Page
image

Segment Disappears and Recipient List Changes
image

Steps to Reproduce

  1. Create a new communication and select a communication list with list-specific segments.
  2. Submit communication for approval.
  3. Communication approver click edit button.
  4. See list-specific segments disappear and the total number of recipients go up due to missing filters.

Expected behavior:

If the Communication Approver clicks "Edit" on the communication, the selected list and any segments specific to that list should be displayed automatically with any segments selected by the sender pre-selected.

Actual behavior:

The communication list-specific segments (configured on the Communication List group settings) disappear when the communication is submitted for approval, and the approver clicks "Edit". The number of recipients also changes until the approver re-segments their communication (if they can figure out which segments they used).

Versions

  • Rock Version: [10.1]
  • Client Culture Setting: [en-US]
@ethan-sparkdevnetwork ethan-sparkdevnetwork added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Mar 4, 2020
@ethan-sparkdevnetwork ethan-sparkdevnetwork self-assigned this Mar 4, 2020
ethan-sparkdevnetwork added a commit that referenced this issue Mar 4, 2020
… the approval process would not display the correct segment filter(s) or segment filter type. (Fixes #4144)
@nairdo nairdo removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Mar 5, 2020
@crayzd92 crayzd92 added this to the v10 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v10.3
Projects
None yet
Development

No branches or pull requests

5 participants