Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EO-764 Adjust signals subtitles, Remove other charts header #1008

Merged
merged 2 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@jonambas
Copy link
Member

commented May 15, 2019

What Changed

  • Removed title from OtherChartsHeader, renamed to Divider
  • Adjusted page subtitles to be more clear

How To Test

To Do

  • Address feedback
@coveralls

This comment has been minimized.

Copy link

commented May 15, 2019

Coverage Status

Coverage increased (+0.002%) to 91.965% when pulling dba5838 on EO-764 into e390da4 on master.

@PatrickSison PatrickSison self-requested a review May 15, 2019

@PatrickSison
Copy link
Contributor

left a comment

Everything else looks good 👍

if (!prefix) {
return null;
const translateFacet = (facet, id) => {
switch (facet) {

This comment has been minimized.

Copy link
@PatrickSison

PatrickSison May 16, 2019

Contributor

Not sure what the styling should be, but should the ID have some separation from the facet label? Seeing IP Pool subaccounts kind of flows as one thing and seems a bit weird. Might be unnecessary fix

This comment has been minimized.

Copy link
@jonambas

jonambas May 20, 2019

Author Member

Yeah, wasn't sure either. The idea was to keep it similar to what were doing with subaccounts - "Subaccount {id}"

@jonambas jonambas merged commit 4d2aa3d into master May 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.