Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attachments #14

Closed
barryoneill opened this issue Jan 9, 2017 · 1 comment
Closed

Add support for attachments #14

barryoneill opened this issue Jan 9, 2017 · 1 comment
Assignees
Milestone

Comments

@barryoneill
Copy link
Collaborator

Add support for retrieving/viewing attachments.

@barryoneill barryoneill added this to the 1.1.0 milestone Jan 9, 2017
@barryoneill barryoneill self-assigned this Jan 9, 2017
barryoneill added a commit that referenced this issue Feb 21, 2017
This is in prep for Issue #14, file attachment support.
kblief added a commit that referenced this issue Feb 22, 2017
Issue #14 - Domain refactoring, upgrades.
barryoneill added a commit that referenced this issue May 23, 2017
@barryoneill barryoneill mentioned this issue May 23, 2017
johnament pushed a commit that referenced this issue May 26, 2017
* Issue #14 - deprecate and toggle 'off' data in message details

* Issue #14 - new attachment model, detect attachments

* Issue #14 - add attachment support

* Issue #14 - add coverage for message GET
barryoneill added a commit that referenced this issue Oct 30, 2017
kblief added a commit that referenced this issue Oct 30, 2017
kblief pushed a commit to kblief/holdmail that referenced this issue Dec 15, 2017
barryoneill added a commit that referenced this issue Jan 20, 2018
barryoneill added a commit that referenced this issue Jan 20, 2018
barryoneill added a commit that referenced this issue Jan 21, 2018
kblief added a commit that referenced this issue Jan 21, 2018
barryoneill added a commit that referenced this issue Jan 22, 2018
@barryoneill
Copy link
Collaborator Author

Ok - this is FINALLY in. Changes:

  • /rest/messages/{messageId} endpoint now delivers an attachments block, for each attachment the following is present:
    • attachmentId - a unique identifier (in the scope of the containing message). This is actually the sequence number of the attachment's position in the MIME body.
    • filename - the filename as set by the mail client
    • contentType - associated content type
    • disposition - Either 'inline' or 'attachment' representing content embedded in the HTML body, or a standalone attachment respectively.
    • sha256sum - to let testers verify the contents of a message without having to fetch it.
    • size - the size in bytes of the attachment
  • /rest/messages/{messageId} no longer delivers messageRAW attribute (performance degradation for attachment users). Use existing /rest/messages/{messageId}/raw* instead.
  • /rest/messages now delivers an additional hasAttachments flag:
    • This only takes those attachments of 'attachment' disposition. Embedded 'inline' don't count.
    • This only works for new messages. Existing messages can be patched if desired with: update message set has_attachments=1 where message_body like '%Content-Disposition: attachment%';
  • A new endpoint, /rest/messages/{messageID}/att/{attachmentId} will serve the content of the specified attachment with the appropriate Content-Type with a Content-Disposition setting the attachment's filename.
  • Rudimentary RFC2231 has been added to support i18n in the MIME headers. This means that subjects and attachments (among other features) should now have multi-language support. (Message bodies previously had no problem).
  • The UI has been updated:
    • The mail list now shows an icon to mark whether a mail has any non-embedded attachments screen shot 2018-01-21 at 11 16 58 pm
    • The mail details now lists any non-embedded attachments as download links. screen shot 2018-01-21 at 11 16 45 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant