Enable a docker plugin for build time image creation (#27) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnament
requested review from
barryoneill,
tsneed290,
kblief,
JasonCaronna and
quest313
johnament
commented
Jan 16, 2018
| rm -rf /var/cache/apk/* | ||
|
|
||
| # Install MySQL Connector | ||
| WORKDIR /opt/holdmail/lib |
There was a problem hiding this comment.
I copied the existing Dockerfile into the root. I'm undecided if we still need the existing docker setup, its good because it includes a docker-compose file, but that may not be long for this earth in favor of k8s.
| @@ -17,5 +17,4 @@ | |||
| ################################################################################ | |||
|
|
|||
|
|
|||
| version=1.0.5-SNAPSHOT | |||
|
|
|||
| version=2.0.0-SNAPSHOT | |||
There was a problem hiding this comment.
This is just an arbitrary change, since the next release will be 2.0.
barryoneill
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Adds gradle commands to create a docker image during the build, based on build output instead.
Changes proposed in this pull request:
Dockerfileinto the root, removing the download part and replacing it with the locally built artifact.Fixes: #27