Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
Adding more typesaftey and benefit of static analyzer.
Before:
After
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No i just started by adding type safety to WithMapping, i could add it for all FromX iterfaces as well but i wouldnt want to make it too big at once.
First i would like to check if you like this before i added generic types everywhere.
3️⃣ Does it include tests, if possible?
No it's just doctype
4️⃣ Any drawbacks? Possible breaking changes?
No breaking changes, no effect on any existing code, even static analyzer with by default assume
mixed
type.5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌
🥳