Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to a work item in the generated living doc includes the physical location of the file #2333

Closed
9 of 36 tasks
godrose opened this issue Feb 28, 2021 · 8 comments
Closed
9 of 36 tasks

Comments

@godrose
Copy link

godrose commented Feb 28, 2021

SpecFlow Version:

  • 3.7
  • 3.6
  • 3.5
  • 3.4
  • 3.3
  • 3.1
  • 3.0
  • 2.4
  • 2.3
  • 2.2
  • 2.1
  • 2.0
  • 1.9

Used Test Runner

  • SpecFlow+Runner
  • MSTest
  • NUnit
  • Xunit

2.4.1

Project Format of the SpecFlow project

  • Classic project format using packages.config
  • Classic project format using <PackageReference> tags
  • Sdk-style project format

.feature.cs files are generated using

  • SpecFlow.Tools.MsBuild.Generation NuGet package
  • SpecFlowSingleFileGenerator custom tool

Visual Studio Version

  • VS 2019
  • VS 2017

Enable SpecFlowSingleFileGenerator Custom Tool option in Visual Studio extension settings

  • Enabled
  • Disabled

Are the latest Visual Studio updates installed?

  • Yes
  • No, I use Visual Studio version <Major>.<Minor>.<Patch>

.NET Framework:

  • >= .NET 4.5
  • before .NET 4.5
  • .NET Core 2.1
  • .NET Core 3.1
  • .NET 5.0

Test Execution Method:

  • Visual Studio Test Explorer
  • TFS/VSTS/Azure DevOps – Task – PLEASE SPECIFY THE NAME OF THE TASK
  • dotnet test livingdoc test-assembly LogoFX.Client.Mvvm.Model.Specs.dll -t TestExecution.json --work-item-url-template 'https://github.com/LogoFX/logofx-client-mvvm-model/issues/{id}' --work-item-prefix WI

<SpecFlow> Section in app.config or content of specflow.json

{
    "bindingCulture":
    {
        "language" :"en-us"
    },
  "language": {
    "feature": "en-us"
  },
    "livingDocGenerator" : {
      "enabled": true,
      "filePath" : "TestExecution.json" 
    } 
}

Issue Description

The title says it all

Steps to Reproduce

Create any project or fork LogoFX.Client.Mvvm.Model at branch v2.2.0-dev
Run the tests and generate the living doc.
Try to click on the WI20 link

Expected: The Github page with the correspondent issues is opened
Actual: It isn't

Repro Project

https://github.com/LogoFX/logofx-client-mvvm-model

@godrose
Copy link
Author

godrose commented Feb 28, 2021

I found the root cause. The '' in the template should be removed.
@SabotageAndi FYI your recent presentation on LivingDoc actually demonstrates terminal with '' which is somewhat misleading

@godrose godrose closed this as completed Feb 28, 2021
@SabotageAndi
Copy link
Contributor

Which command line did you use? I am using PowerShell and there I needed the single quotes around the URL to get it to work, because the PowerShell expands the {id}.

@godrose
Copy link
Author

godrose commented Feb 28, 2021

Which command line did you use? I am using PowerShell and there I needed the single quotes around the URL to get it to work, because the PowerShell expands the {id}.

cmd

@SabotageAndi
Copy link
Contributor

I will talk with the team about this.

@SabotageAndi SabotageAndi added this to To do in OSS Iteration 2 via automation Mar 30, 2021
@mariostnr mariostnr moved this from To do to In progress in OSS Iteration 2 May 19, 2021
@mariostnr
Copy link
Contributor

@godrose the bug fix will be available with our next SpecFlow+ LivingDoc Release

OSS Iteration 2 automation moved this from In progress to Done May 19, 2021
@epresi
Copy link
Contributor

epresi commented Jun 18, 2021

We released a new version with the fix.

@godrose
Copy link
Author

godrose commented Jun 18, 2021 via email

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants