Automatically include TechTalk.SpecFlow.MSTest.SpecFlowPlugin.dll as a deployment item for MSTest V2

[icnocop]

Fixes #2076

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• Performance improvement
• Refactoring (so no functional change)
• Other (docs, build config, etc)

Checklist:

• I've added tests for my code. (most of the time mandatory)
• I have added an entry to the changelog. (mandatory)
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[SabotageAndi]

This will always put a [DeploymentItem] attribute on every feature class. Which has a side effect for users, that don't have deployment items yet. When using DeploymentItems, the output path is different as without any. It will switch to the TestResults folder from the output directory.

Could you only add the attribute, if there is a deployment item somewhere in the feature file set?

[icnocop]

Done.

Thank you.

[SabotageAndi]

Cool, thanks for the change.
One thing I am not sure atm. Can't be the @deploymentitem tag be also on a scenario? In that case, no attribute is added to the class.

[icnocop]

Thank you.

I also considered that case and so I tested adding @MsTest:DeploymentItem:test.txt to a Scenario, but the DeploymentItemAttribute was not added to either the test class or the test method.

According to https://docs.specflow.org/projects/specflow/en/latest/Integrations/MsTest.html:

Tags for TestClass Attributes
The MsTest Generator can generate test class attributes from tags specified on a feature.

[SabotageAndi]

Strange, because I just found code for it on Scenario/method level: https://github.com/SpecFlowOSS/SpecFlow/blob/master/TechTalk.SpecFlow.Generator/UnitTestProvider/MsTestV2GeneratorProvider.cs#L100

[icnocop]

It seems that code was added as part of #1671 but no tests were created specifically for it.

[icnocop]

I'm wondering if any code coverage tools could have picked up the untested code. 🤷🏼‍♂️

[icnocop]

Also see #803 (comment).

The original implementation only supported the tag on the feature level.

[SabotageAndi]

I added a PR to add the missing test for this: #2302
It's green, so it is working.
No idea, why we didn't add the scenario back then.

[SabotageAndi]

Ok, I had a deeper look at it. DeploymentItems on Scenario level are still only half-implemented. They are missing in SetTestMethodCategories.

I would merge this PR now @icnocop and create an issue for fixing the implementation. Ok?

[SabotageAndi]

@icnocop I merged it now, because we are before a release and want to include this in it, as it changes the code-behind file generation.

[icnocop]

Thank you.

[SabotageAndi]

Thanks for your contribution to SpecFlow @icnocop!
Please submit it to our SpecFlow Community Heroes program at https://specflow.org/community/community-hero-program/