introduce and use TagHelper in UnitTestGeneration #2410
Conversation
| @@ -0,0 +1,31 @@ | |||
| namespace TechTalk.SpecFlow | |||
| { | |||
| #nullable enable | |||
There was a problem hiding this comment.
FYI: enabled nullable reference types for this file
|
|
||
| for (int i = 0; i < tags.Length; i++) | ||
| { | ||
| if (string.Equals(tags[i], "ignored", System.StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Using OrdinalIgnoreCase here
| /// <summary> | ||
| /// Provides helper methods around tags. | ||
| /// </summary> | ||
| public static class TagHelper |
There was a problem hiding this comment.
The intention is to extend this helper with other methods like Combine(scenariotags, featuretags), CombineDistinct(scenariotags, featuretags), ...
|
@SabotageAndi Could you share the path forward with the open PR like this one? Thanks |
|
WTH, how did this PR passed me? It's from April. |
|
Looks good @bollhals. Could you add a changelog entry? Then I will merge it. |
bollhals
force-pushed
the
feature/tagCodeGeneration
branch
from
0e83d44
to
2fcc1f2
Compare
bollhals
force-pushed
the
feature/tagCodeGeneration
branch
from
2fcc1f2
to
fcab8d3
Compare
Friendly ping |
|
@bollhals there was a problem with tests in a pipeline. I restarted the pipeline now. Lets see if it is working now. |
|
👍🏼 looks like it worked |
|
Friendly reminder @SabotageAndi |
|
reminder |
|
@SabotageAndi This is still open =) |
|
Sorry for the delay. 😞 |
|
Thanks for your contribution to SpecFlow. |
Types of changes
Changes in a generated unit test (1. Image old, 2nd is new)
featureTags to be static
in FeatureSetup to pass said featureTags directly instead of creating a new array
all instance methods to be non virtual
to call TagHelper instead of individual LINQ
Checklist: