Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ParallelizeDecorator introduced in #746 #2444

merged 5 commits into from Jun 14, 2021


Copy link

@shack05 shack05 commented Jun 12, 2021

Fixes #2442
Removes ParallelizeDecorator feature introduced in #746

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)


  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@shack05 shack05 changed the title Fix/2442 Remove ParallelizeDecorator introduced in #746 Jun 12, 2021
Copy link
Contributor Author

shack05 commented Jun 12, 2021

I noticed the test XUnit2TestGeneratorProvider_WithFeatureWithMatchingTag_ShouldAddNonParallelizableCollectionAttribute I introduced in my previous PR should be failing.

This assertion should fail because I changed the argument of the XUnit collection attribute from NonParallelizable to SpecFlowNonParallelizableFeatures.

Changing lines 424-426 to the following will fix it:

attributes.Should().ContainSingle(a => a.Name == XUnitCollectionAttribute);
var collectionAttribute = attributes.Single(a => a.Name == XUnitCollectionAttribute);
collectionAttribute.Arguments[0].Value.Should().BeEquivalentTo(new CodePrimitiveExpression("SpecFlowNonParallelizableFeatures"));

Do you want me to include that change in this PR?

Copy link

@epresi epresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shack05!
I would merge this one, so please fix the test in a new PR.

@epresi epresi merged commit 784cbf2 into SpecFlowOSS:master Jun 14, 2021
Copy link

Thanks for your contribution to SpecFlow.
Please submit your contributions to our SpecFlow Community Heroes program at

Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023

* Remove ParallelizeDecorator and related unit tests.

* Remove IUnitTestGeneratorProvider.SetTestClassParallelize method.

* Remove Parallelizable attribute from NUnit3TestGeneratorProvider.

* Remove two generator configuration items related to the ParallelizableDecorator.

* Update changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Remove ParallelizeDecorator introduced in #746
3 participants