From 210ad3f998bcf6d33e9c7b9f986c1ef1a002ba4f Mon Sep 17 00:00:00 2001 From: kaatr Date: Wed, 9 Jul 2025 12:41:59 +0300 Subject: [PATCH] sai-cli diagnose: Remove --output_json option and make --output_html positional argument --- python/cli/diagnose/diagnose.py | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/python/cli/diagnose/diagnose.py b/python/cli/diagnose/diagnose.py index dbba23d..fec1015 100644 --- a/python/cli/diagnose/diagnose.py +++ b/python/cli/diagnose/diagnose.py @@ -12,8 +12,7 @@ def define_args(parser): parser.add_argument("dataset_path", type=pathlib.Path, help="Path to dataset") - parser.add_argument("--output_html", type=pathlib.Path, help="Path to calibration report HTML output.") - parser.add_argument("--output_json", type=pathlib.Path, help="Path to JSON output.") + parser.add_argument("output_html", type=pathlib.Path, help="Path to calibration report HTML output.") parser.add_argument("--zero", help="Rescale time to start from zero", action='store_true') parser.add_argument("--skip", type=float, help="Skip N seconds from the start") parser.add_argument("--max", type=float, help="Plot max N seconds from the start") @@ -38,10 +37,6 @@ def generateReport(args): 'dataset_path': str(jsonlFile.parent) } - if not args.output_html and not args.output_json: - print("Either --output_html or --output_json is required") - return - data = { 'accelerometer': {"v": [], "t": [], "td": []}, 'gyroscope': {"v": [], "t": [], "td": []}, @@ -138,18 +133,10 @@ def addMeasurement(type, t, v): diagnoseGNSS(data, output) diagnoseCpu(data, output) - if args.output_json: - if os.path.dirname(args.output_json): - os.makedirs(os.path.dirname(args.output_json), exist_ok=True) - with open(args.output_json, "w") as f: - f.write(json.dumps(output, indent=4)) - print("Generated JSON report data at:", args.output_json) - - if args.output_html: - if os.path.dirname(args.output_html): - os.makedirs(os.path.dirname(args.output_html), exist_ok=True) - generateHtml(output, args.output_html) - print("Generated HTML report at:", args.output_html) + if os.path.dirname(args.output_html): + os.makedirs(os.path.dirname(args.output_html), exist_ok=True) + generateHtml(output, args.output_html) + print("Generated HTML report at:", args.output_html) if __name__ == '__main__': def parse_args():