Skip to content

Updating xmlParseMemory to xmlReadMemory #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpmoore merged 1 commit into from
Oct 1, 2019
Merged

Updating xmlParseMemory to xmlReadMemory #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ install_manifest.txt
# eclipse IDE config files
.cproject
.project

*.cbp
2 changes: 1 addition & 1 deletion src/ds3_requests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ static ds3_error* _get_request_xml_nodes(
char* root_element_name) {
xmlNodePtr root;

xmlDocPtr doc = xmlParseMemory((const char*) xml_blob->data, xml_blob->len);
xmlDocPtr doc = xmlReadMemory((const char*) xml_blob->data, xml_blob->len, NULL, NULL, XML_PARSE_HUGE);
Copy link
Contributor

@RachelTucker RachelTucker Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi this is an auto-gened file

Copy link
Contributor Author

@rpmoore rpmoore Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we'll need that change reflected there as well.

if (doc == NULL) {
char* message = g_strconcat("Failed to parse response document. The actual response is: ", xml_blob->data, NULL);
g_byte_array_free(xml_blob, TRUE);
Expand Down