Skip to content

Delete requests were expecting the wrong HTTP status code. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpmoore merged 1 commit into from
Apr 8, 2014
Merged

Delete requests were expecting the wrong HTTP status code. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/spectralogic/ds3client/commands/DeleteBucketResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ public DeleteBucketResponse(CloseableHttpResponse response) throws IOException {

@Override
protected void processResponse() throws IOException {
checkStatusCode(200);
checkStatusCode(204);
}
}
2 changes: 1 addition & 1 deletion src/main/java/com/spectralogic/ds3client/commands/DeleteObjectResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ public DeleteObjectResponse(CloseableHttpResponse response) throws IOException {

@Override
protected void processResponse() throws IOException {
checkStatusCode(200);
checkStatusCode(204);
}
}
4 changes: 2 additions & 2 deletions src/test/java/com/spectralogic/ds3client/Ds3Client_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ void validate(PutBucketRequest request) {
public void deleteBucket() throws IOException, SignatureException {
new NonStrictExpectations() {{
netClient.getResponse(withInstanceOf(DeleteBucketRequest.class));
result = new MockedResponse("", 200).getMockInstance();
result = new MockedResponse("", 204).getMockInstance();
forEachInvocation = new Object() {
void validate(DeleteBucketRequest request) {
assertThat(request.getPath(), is("/bucketName"));
Expand All @@ -154,7 +154,7 @@ void validate(DeleteBucketRequest request) {
public void deleteObject() throws IOException, SignatureException {
new NonStrictExpectations() {{
netClient.getResponse(withInstanceOf(DeleteObjectRequest.class));
result = new MockedResponse("", 200).getMockInstance();
result = new MockedResponse("", 204).getMockInstance();
forEachInvocation = new Object() {
void validate(DeleteObjectRequest request) {
assertThat(request.getPath(), is("/bucketName/my/file.txt"));
Expand Down